Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding objects via YML #92

Open
Firesphere opened this issue Nov 24, 2015 · 6 comments

Comments

@Firesphere
Copy link

@Firesphere Firesphere commented Nov 24, 2015

Title speaks for itself.

@smokeycam

This comment has been minimized.

Copy link

@smokeycam smokeycam commented Jan 13, 2016

Big +1 on this one

@wilr

This comment has been minimized.

Copy link
Owner

@wilr wilr commented Jan 13, 2016

@Firesphere @smokeycam any reason you're unhappy about the PHP API? it would be easy to add support for YAML. Simply have:

GoogleSitemap:
register_dataobjects:
- Foo
- Bar

@smokeycam

This comment has been minimized.

Copy link

@smokeycam smokeycam commented Jan 13, 2016

Hiya @wilr , maybe its me, that I am not doing this correctly. I have this in my modules YML files, but not having any effect.. any ideas?

GoogleSitemap:
register_dataobjects:
- Property
- 'Daily'

@wilr

This comment has been minimized.

Copy link
Owner

@wilr wilr commented Jan 13, 2016

So that won't work, was just wondering if that sort of YAML API is what you wanted.

@tractorcow

This comment has been minimized.

Copy link
Contributor

@tractorcow tractorcow commented Jan 13, 2016

I think the idea is that could be the API. Someone would still need to add support for it in the module. :D

@smokeycam

This comment has been minimized.

Copy link

@smokeycam smokeycam commented Jan 13, 2016

Oh yes, that would be ideal for me. I can always just use the _config.php
in the interim. As i am relatively new to Silverstipe and was just setting
up a 'standardised(?)' configuration setup. Having said that, a little off
topic, but is the YML config setup with Silverstipe the preferred way, or
is it an 'either one or both' (yml/_config.php) senario?

Thanks for clearing that all up.

Cheers!

On Wed, Jan 13, 2016 at 9:17 PM, Will Rossiter notifications@github.com
wrote:

So that won't work, was just wondering if that sort of YAML API is what
you wanted.


Reply to this email directly or view it on GitHub
#92 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.