Skip to content

Andy Wilson
wilsaj

Organizations

@twdb @open-austin @TNRIS @atx-osg @MaptimeATX
Jun 24, 2016
@wilsaj
Jun 23, 2016
wilsaj commented on pull request TNRIS/flood#105
@wilsaj

My thoughts: The tradeoff for the separate MDL fork is that the MDL source is easier to navigate and track changes, but it has the cost of a separa…

Jun 22, 2016
wilsaj commented on pull request TNRIS/flood#107
@wilsaj

sounds good

Jun 22, 2016
wilsaj pushed to master at TNRIS/flood
@wilsaj
Jun 22, 2016
wilsaj merged pull request TNRIS/flood#107
@wilsaj
add simple noscript message
1 commit with 7 additions and 1 deletion
Jun 22, 2016
wilsaj commented on pull request TNRIS/flood#107
@wilsaj

Sorry for underspecifying - at the time it was more of a note-to-self. I don't mind merging as is, but I'd also like to include some conditional te…

Jun 22, 2016
wilsaj pushed to master at TNRIS/flood
@wilsaj
Jun 22, 2016
wilsaj merged pull request TNRIS/flood#111
@wilsaj
change exchange smart quotes for dumb quotes in disclaimer
1 commit with 1 addition and 1 deletion
Jun 22, 2016
wilsaj commented on issue TNRIS/flood#100
@wilsaj

deployed - but with an ugly encoding issue (see #110)

Jun 22, 2016
wilsaj opened issue TNRIS/flood#110
@wilsaj
bad encoding around quotes for legal disclaimer
Jun 22, 2016
wilsaj commented on pull request TNRIS/flood#105
@wilsaj

deployed

Jun 21, 2016
wilsaj commented on pull request TNRIS/flood#105
@wilsaj

I'm not sure if we can directly push to this PR since it's in a private fork, so any changes from me or you would need to be done as separate PR. I…

Jun 21, 2016
wilsaj commented on pull request TNRIS/flood#105
@wilsaj

@sashahart and @christoball are you ok with merging and deploying this as is?

Jun 21, 2016
wilsaj commented on issue TNRIS/flood#108
@wilsaj

Just did some testing and this doesn't appear to be affecting production builds, as tested by: npm run dist cd dist/ python -m SimpleHTTPServer Wi…

Jun 18, 2016
wilsaj commented on pull request TNRIS/flood#109
@wilsaj

The problem is that, for some reason, FF hasn't set the map div element size at the time that L.map() is called so it renders it all janky. Whether…

Jun 18, 2016
wilsaj commented on pull request TNRIS/flood#107
@wilsaj

Maybe also link to http://enable-javascript.com/ ?

Jun 17, 2016
wilsaj commented on pull request TNRIS/flood#109
@wilsaj

The purpose of fitBounds is to support multiple screen sizes. A small smartphone screen needs to be zoomed out to about zoom level 5 in order to fi…

Jun 17, 2016
wilsaj commented on issue TNRIS/flood#40
@wilsaj

Yep, this can be closed

Jun 17, 2016
wilsaj commented on issue TNRIS/flood#77
@wilsaj

There should be analytics events for actions to get a sense for how users are interacting with the app. Things like: turning on and off layers ope…

Jun 17, 2016
wilsaj commented on issue TNRIS/flood#38
@wilsaj

Right now, this relies on CartoDB's sync table but that can sometimes error out and gets stuck so it stops updating. We need a more reliable - eith…

Jun 17, 2016
wilsaj commented on issue TNRIS/flood#88
@wilsaj

Yeah, I totally understand and appreciate your efforts - I'm just weighing in where I can. I guess this is up to Richard and Miguel to decide wheth…

Jun 17, 2016
wilsaj commented on pull request TNRIS/flood#105
@wilsaj

Looks alright to me, though I think it's weird and unfriendly to greet first-time users with a legal wall of text that is most likely going to be d…

Jun 17, 2016
wilsaj commented on issue TNRIS/flood#88
@wilsaj

I think what happened is that before the legend info was added, the content was small enough that it wasn't noticed in most cases. Now there is eno…

Jun 17, 2016
wilsaj commented on issue TNRIS/flood#88
@wilsaj

Setting overflow:hidden (option 3) makes it impossible to scroll in a lot of common contexts (for example, I can't use the trackpad on my laptop).

Jun 17, 2016
wilsaj commented on pull request TNRIS/flood#104
@wilsaj

I agree with all of those points. I'm not proud of how much technical debt this project has racked up in its short lifetime but I'll try to point i…

Jun 17, 2016
wilsaj commented on pull request TNRIS/flood#104
@wilsaj

Oh hey, one thing - we have a fork of the material-design-lite library https://github.com/TNRIS/material-design-lite that is intended to track chan…

Jun 16, 2016
wilsaj pushed to master at TNRIS/flood
@wilsaj
Jun 16, 2016
wilsaj merged pull request TNRIS/flood#99
@wilsaj
stop "npm install" failing due to pinned version conflict
1 commit with 1 addition and 1 deletion
Jun 16, 2016
wilsaj pushed to master at TNRIS/flood
@wilsaj
Jun 16, 2016
wilsaj merged pull request TNRIS/flood#102
@wilsaj
shinkwrap dependencies
1 commit with 5,372 additions and 0 deletions
Something went wrong with that request. Please try again.