Permalink
Commits on Aug 25, 2008
  1. It's not FLAC -> military police

    committed Aug 25, 2008
Commits on Jul 30, 2008
  1. Removing default options in flac2mp3 command.

    Default options would make a config file not very useful, since the passed-in options trump the config.
    ymendel committed Jul 30, 2008
  2. Removing filename duplication.

    This isn't needed anymore since Flac2mp3 handles the quoting now instead of the String itself being extended in order to quote itself.
    ymendel committed Jul 30, 2008
  3. Using both config and options.

    Options trump config values.
    Setting @config in initialization is the cleanest way to get the 'when intialized should load the configuration' spec to stay passing.
    ymendel committed Jul 30, 2008
  4. Continuing refactoring of option-setting and -querying in spec, getti…

    …ng out of initialization.
    ymendel committed Jul 30, 2008
  5. Adding configuration-loading.

    Config will be stored as YAML in the file ~/.flac2mp3
    ymendel committed Jul 30, 2008
Commits on Jul 25, 2008
  1. Removing no-longer relevant specs and code.

    All the class- (originally module-) level stuff for converting flac to mp3 is unneeded. Instances handle that stuff now.
    ymendel committed Jul 25, 2008
  2. Changing Flac2mp3.convert to instantiate an object and call #convert.

    This is what it's all about, folks.
    ymendel committed Jul 25, 2008
  3. Defining Flac2mp3#set_mp3data.

    The implementation and the specs were almost entirely pulled from the previous incarnation as Flac2mp3.mp3data. There's definitely some cleanup possible here, but that's for a later refactoring.
    ymendel committed Jul 25, 2008
  4. Defining Flac2mp3#get_flacdata.

    This is almost identical to the previous incarnation as Flac2mp3.flacdata, and it uses the same method of knowing which fields should stay strings. This is just the start of the instance accessing what was previously a private class method, so the access restrictions are off (at least for now).
    ymendel committed Jul 25, 2008
  5. Defining Flac2mp3#convert_metadata.

    This simply gets the flac data and sets the mp3 data accordingly.
    ymendel committed Jul 25, 2008
  6. Query method for :encoding option.

    Including default of --preset standard.
    ymendel committed Jul 25, 2008
  7. Defining Flac2mp3#mp3_command.

    Like #flac_command, it takes a filename, quotes it, and checks if the command should be silent. Unlike #flac_command, it also checks what encoding to use.
    ymendel committed Jul 25, 2008
Commits on Jul 24, 2008
  1. Adding filename quoting in Flac2mp3#safequote.

    Pulling over the behavior from the string extension. This is really more of a Flac2mp3 concern than a String concern, even if the behavior is put in a module and only applied to certain strings.
    ymendel committed Jul 24, 2008
  2. Query method for :silent option.

    ymendel committed Jul 24, 2008
  3. Defining Flac2mp3#flac_command.

    Takes a filename, quotes it safely (since this is for a shell command), and checks if the command should be silent.
    ymendel committed Jul 24, 2008
  4. Continuing Flac2mp3 cleanup, defining Flac2mp3#convert_data.

    This is the main "cheating" step, where I just shell out to other commands to do the bulk of the conversion work.
    ymendel committed Jul 24, 2008
  5. More Flac2mp3 cleanup, defining Flac2mp3#process_conversion.

    This simply converts the data (as in the files themselves) and then the metadata (the tags).
    Flac2mp3#convert called this with the input and output filenames, but it makes more sense to move the output filename stuff into this method.
    ymendel committed Jul 24, 2008
  6. Starting cleanup of Flac2mp3 behavior, making a good class out of thi…

    …s instead of a messy module.
    
    Storing options was one step. This starts with querying an option and a short, simple Flac2mp3#convert method.
    ymendel committed Jul 24, 2008
Commits on Jul 21, 2008
Commits on Jul 18, 2008
Commits on Jun 28, 2008