Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

mysql extension is not removed since 5.0 #8

Closed
baschny opened this Issue Mar 14, 2013 · 1 comment

Comments

Projects
None yet
1 participant
Contributor

baschny commented Mar 14, 2013

See: http://www.php.net/manual/en/intro.mysql.php. mysql_ is only "deprecated" since 5.5 It works perfectly well in 5.0 .. 5.4. So there is a bug in the array in Sniffs/PHP/RemovedExtensionsSniff.php. Should read:

        'mysql_' => array(
                '5.0' => 1,
                '5.1' => 1,
                '5.2' => 1,
                '5.3' => 1,
                '5.4' => 1,
                '5.5' => -1,
                'alternative' => 'mysqli',
        ),

instead of

        'mysql_' => array(
                '5.0' => 0,
                '5.1' => 0,
                '5.2' => 0,
                '5.3' => 0,
                '5.4' => 0,
                '5.5' => -1,
                'alternative' => 'mysqli',
        ),

@baschny baschny added a commit to baschny/PHPCompatibility that referenced this issue Mar 14, 2013

@baschny baschny Fixes #8: mysql_ extension still supported until PHP 5.4 acab657
Contributor

baschny commented Mar 14, 2013

Close in favor of #9.

@baschny baschny closed this Mar 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment