Recognize T_SELF as well in variable variables. #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes failing unit tests caused by changed behaviour of PHPCS > 2.7.1. See: * squizlabs/PHP_CodeSniffer@79cd3dc * squizlabs/PHP_CodeSniffer#1245
|
@wimg Seems coveralls has changed something causing these notices to show up again. Would you mind turning them off again ? |
|
@jrfnl For some reason I can't turn it off. I click the checkbox, click save, but it just reappears :-( |
|
@wimg Time to file a bug report ? |
|
@wimg On that same note, Coveralls is not reporting the coverage anymore for master -> see the button in the readme. |
|
Let's given them a bit of time. I'm thinking they're having some issues ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing unit tests caused by changed behavior of PHPCS > 2.7.1.
See: