Sync the `getMethodParameters()` method with the version now merged in PHPCS #326

Merged
merged 1 commit into from Jan 15, 2017

Projects

None yet

3 participants

@jrfnl
Contributor
jrfnl commented Jan 4, 2017

The getMethodParameters() method in the PHPCompatibility_Sniff class is a duplicate of an upstream method. The upstream method missed some type hints and didn't recognize nullable types.
The upstream PRs fixing this have now been merged with some very minor changes to the original merge proposal.

This PR syncs the duplicate method in the PHPCompatibility_Sniff class with the version as now merged upstream.

To maintain compatibility with PHPCS version lower than the current dev-master, the method cannot be removed until the minimum PHPCS version for the PHPCompatibility library has moved beyond the version in which these changes have been merged.

@jrfnl jrfnl Sync the `getMethodParameters()` method with the version now merged i…
…n PHPCS.
196892d
@coveralls
coveralls commented Jan 4, 2017 edited

Coverage Status

Coverage remained the same at 96.861% when pulling 196892d on jrfnl:feature/sync-copied-method-with-phpcs into 4853c6d on wimg:master.

@coveralls
coveralls commented Jan 4, 2017 edited

Coverage Status

Coverage remained the same at 96.861% when pulling 196892d on jrfnl:feature/sync-copied-method-with-phpcs into 4853c6d on wimg:master.

@wimg wimg merged commit 482bc3c into wimg:master Jan 15, 2017

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jrfnl jrfnl deleted the jrfnl:feature/sync-copied-method-with-phpcs branch Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment