Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes: mysql_ extension still supported until PHP 5.4 #9

Merged
merged 1 commit into from Mar 14, 2013

Conversation

Projects
None yet
3 participants
Contributor

baschny commented Mar 14, 2013

Sorry, I was not aware that opening a pull request also opened an issue. So I'm keeping this one (#9) and deleting the previous one (#8):

See: http://www.php.net/manual/en/intro.mysql.php. mysql_ is only "deprecated" since 5.5 It works perfectly well in 5.0 .. 5.4. So there is a bug in the array in Sniffs/PHP/RemovedExtensionsSniff.php. Should read:

        'mysql_' => array(
                '5.0' => 1,
                '5.1' => 1,
                '5.2' => 1,
                '5.3' => 1,
                '5.4' => 1,
                '5.5' => -1,
                'alternative' => 'mysqli',
        ),

instead of

        'mysql_' => array(
                '5.0' => 0,
                '5.1' => 0,
                '5.2' => 0,
                '5.3' => 0,
                '5.4' => 0,
                '5.5' => -1,
                'alternative' => 'mysqli',
        ),
Owner

wimg commented Mar 14, 2013

Wow that's a pretty big one... sorry about that. Must have been very tired when I did that :-(

wimg added a commit that referenced this pull request Mar 14, 2013

Merge pull request #9 from baschny/issue_8
Fixes: mysql_ extension still supported until PHP 5.4

@wimg wimg merged commit 4ced95a into wimg:master Mar 14, 2013

@jrfnl jrfnl modified the milestone: 5.5 Apr 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment