New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two minor bugs: missing NULL check and breakage on Windows #1

Open
wimleers opened this Issue Apr 2, 2013 · 0 comments

Comments

Projects
None yet
1 participant
@wimleers
Owner

wimleers commented Apr 2, 2013

Reported at http://wimleers.com/comment/1746#comment-1746:

QGeoIP.cpp line 76 calls GeoIP_time_zone_by_country_and_region using r->country_code and r->region before checking if r is null on line 78.
In addition, line 120 attempts to open the databases using the GEOIP_MMAP_CACHE flag, which is unavailable on Windows. This results in a segfault at the first lookup attempt, so a different flag or OS checking may be wise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment