Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

fix for utf8 encoding and setting order

  • Loading branch information...
commit 70dd61f91d04f6c65d3b25f7da9c096e7d0ec43c 1 parent 7f31ed0
@andyshinn andyshinn authored
Showing with 4 additions and 4 deletions.
  1. +4 −4 fileconveyor/transporters/transporter_s3.py
View
8 fileconveyor/transporters/transporter_s3.py
@@ -29,10 +29,10 @@ def __init__(self, settings, callback, error_callback, parent_logger=None):
# Map the settings to the format expected by S3Storage.
try:
self.storage = S3BotoStorage(
- self.settings["bucket_name"],
- self.settings["bucket_prefix"],
- self.settings["access_key_id"],
- self.settings["secret_access_key"],
+ self.settings["bucket_name"].encode('utf-8'),
+ self.settings["access_key_id"].encode('utf-8'),
+ self.settings["secret_access_key"].encode('utf-8'),
+ "public-read",
"public-read",
self.__class__.headers
)

2 comments on commit 70dd61f

@Azrael808

Hey, I've just started using Fileconveyor and I noticed that when I pass a bucket_prefix argument, it's not honoured for the uploaded files. This commit seems to have removed it? Is that intended?

@andyshinn

Looks like you are correct. This is an oversight on my part. Have you tried manually added the line to the mix:

self.storage = S3BotoStorage(
                self.settings["bucket_name"].encode('utf-8'), 
                self.settings["bucket_prefix"].encode('utf-8'),
                self.settings["access_key_id"].encode('utf-8'),
                self.settings["secret_access_key"].encode('utf-8'),
                "public-read",
Please sign in to comment.
Something went wrong with that request. Please try again.