Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix for UTF8 setting encoding and setting order for S3 #137

Merged
merged 1 commit into from

3 participants

@andyshinn

This is a fix for issue #124 requested by Wim.

@wimleers wimleers merged commit ca3585e into from
@Azrael808

Hey, I've just started using Fileconveyor and I noticed that when I pass a bucket_prefix argument, it's not honoured for the uploaded files. This commit seems to have removed it? Is that intended?

Looks like you are correct. This is an oversight on my part. Have you tried manually added the line to the mix:

self.storage = S3BotoStorage(
                self.settings["bucket_name"].encode('utf-8'), 
                self.settings["bucket_prefix"].encode('utf-8'),
                self.settings["access_key_id"].encode('utf-8'),
                self.settings["secret_access_key"].encode('utf-8'),
                "public-read",
@andyshinn andyshinn deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 17, 2013
  1. @andyshinn
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 4 deletions.
  1. +4 −4 fileconveyor/transporters/transporter_s3.py
View
8 fileconveyor/transporters/transporter_s3.py
@@ -29,10 +29,10 @@ def __init__(self, settings, callback, error_callback, parent_logger=None):
# Map the settings to the format expected by S3Storage.
try:
self.storage = S3BotoStorage(
- self.settings["bucket_name"],
- self.settings["bucket_prefix"],
- self.settings["access_key_id"],
- self.settings["secret_access_key"],
+ self.settings["bucket_name"].encode('utf-8'),
+ self.settings["access_key_id"].encode('utf-8'),
+ self.settings["secret_access_key"].encode('utf-8'),
+ "public-read",
"public-read",
self.__class__.headers
)
Something went wrong with that request. Please try again.