Make a note about missing bundler, it's a gotcha for non-Ruby users. #45

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

No description provided.

Owner

wincent commented Jun 27, 2012

Thanks for the pull request.

Looking at it, I don't think we should be using Bundler for this at all; it's just confusing the issue. The bundle was added in commit c9fad73, but it doesn't seem necessary at all as there is nothing in rake make that should need it (all rake make is doing is ruby extconf.rb && make).

Ok, I'll close this pull request then.

Owner

wincent commented Jun 27, 2012

Fixed in commit e926704, which should mirror over to GitHub shortly. I didn't apply your pull request, but I did credit you with identifying the problem in the commit message.

Thanks once again.

blueyed pushed a commit to blueyed/Command-T that referenced this pull request Dec 16, 2014

doc: don't suggest `bundle install`
As suggested by Denis Malinovsky here:

  wincent#45

Asking people to use Bundler may cause confusion for non-Rubyists, and
Bundler doesn't acutally buy us anything. The `bundle` was added in
commit c9fad73, but there's nothing in the Rakefile that would
require us to use Bundler for the "make" task (it's literally just
equivalent to `ruby extconf.rb && make`).

Keep things simple and take Bundler out of the picture.

Signed-off-by: Wincent Colaiuta <win@wincent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment