New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:Ack does not find strings after 4.0.0 update #59

Closed
kjivan opened this Issue Jan 10, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@kjivan
Copy link

kjivan commented Jan 10, 2019

After the 4.0.0 update the :Ack command no longer finds strings that exists in files.

By the way; thanks for a great plugin!

Let me know if you need anymore info.

Environment:
OS: Ubuntu 16.04
Search executable: rg
vim:

NVIM v0.3.1
Build type: RelWithDebInfo
LuaJIT 2.0.4
Compilation: /usr/bin/x86_64-linux-gnu-gcc -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -DDISABLE_LOG -Wdate-time -D_FORTIFY_SOURCE=2 -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -O2 -g -DMIN_LOG_LEVEL=3 -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -Wno-array-bounds -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_UNIBI_HAS_VAR_FROM -I/build/neovim-xZey2V/neovim-0.3.1/build/config -I/build/neovim-xZey2V/neovim-0.3.1/src -I/usr/include -I/build/neovim-xZey2V/neovim-0.3.1/build/src/nvim/auto -I/build/neovim-xZey2V/neovim-0.3.1/build/include
Compiled by team+vim@tracker.debian.org

Features: +acl +iconv +jemalloc +tui
See ":help feature-compile"

system vimrc file: "$VIM/sysinit.vim"
fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info

@kjivan kjivan changed the title Ack does not find strings after 4.0.1 update Ack does not find strings after 4.0.0 update Jan 10, 2019

@kjivan kjivan changed the title Ack does not find strings after 4.0.0 update :Ack does not find strings after 4.0.0 update Jan 10, 2019

@kjivan

This comment has been minimized.

Copy link

kjivan commented Jan 10, 2019

Seems to be an issue isolated to ripgrep. I installed the silver searcher and switch the executable to ag and it started working.

@kjivan

This comment has been minimized.

Copy link

kjivan commented Jan 10, 2019

Figured it out. I needed to update ripgrep >= 0.8 when the no-config option was added. Which is need due to this.

It might be worth adding a min version comment to the readme or even better printing out a message in vim that the user should update the ripgrep.

@kjivan kjivan closed this Jan 10, 2019

@wincent

This comment has been minimized.

Copy link
Owner

wincent commented Jan 10, 2019

Thanks for bringing this up. I think I can add some feature detection here to make this degrade gracefully with older versions of ripgrep.

wincent added a commit that referenced this issue Jan 10, 2019

Make use of `rg --no-config` conditional via feature detection
Addresses:

    #59

wherein it was reported that only rg version 0.8 and about supports the
`--no-config` switch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment