New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching node version specified in package.json #175

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Projects
None yet
3 participants
@Jkat
Contributor

Jkat commented Oct 11, 2018

Code is probably referencing the right requirements, otherwise tests would be failing ;)

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 11, 2018

Pull Request Test Coverage Report for Build 489

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.596%

Totals Coverage Status
Change from base Build 484: 0.0%
Covered Lines: 413
Relevant Lines: 431

💛 - Coveralls

coveralls commented Oct 11, 2018

Pull Request Test Coverage Report for Build 489

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.596%

Totals Coverage Status
Change from base Build 484: 0.0%
Covered Lines: 413
Relevant Lines: 431

💛 - Coveralls
@JirkaChadima

This comment has been minimized.

Show comment
Hide comment
@JirkaChadima

JirkaChadima Oct 11, 2018

Member

Oh, thanks for catching this, I totally forgot we have that in readme. And as usual, it's actually not that simple :)

  • For development and CI, we use version from .nvmrc which has to be pinned exactly. So that's 10.7.0 right now.
  • When running from Docker, we use node:10 as a base image which I think currently resolves to 10.11 and they don't keep the older 10.x versions (or I was not able to find them).

So we are sure that the code works on 10.7 because our CI runs on that. And we are kind of sure that the latest 10.x node is working, because our deployments are running.

I'm going to merge this and create an issue to clean this up, we should be running CI on both 10.latest and the version specified in .nvmrc and we should probably be bumping node versions in .nvmrc regularly.

Member

JirkaChadima commented Oct 11, 2018

Oh, thanks for catching this, I totally forgot we have that in readme. And as usual, it's actually not that simple :)

  • For development and CI, we use version from .nvmrc which has to be pinned exactly. So that's 10.7.0 right now.
  • When running from Docker, we use node:10 as a base image which I think currently resolves to 10.11 and they don't keep the older 10.x versions (or I was not able to find them).

So we are sure that the code works on 10.7 because our CI runs on that. And we are kind of sure that the latest 10.x node is working, because our deployments are running.

I'm going to merge this and create an issue to clean this up, we should be running CI on both 10.latest and the version specified in .nvmrc and we should probably be bumping node versions in .nvmrc regularly.

@JirkaChadima JirkaChadima merged commit f547eee into windingtree:develop Oct 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.596%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment