New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HamburgerVisibility property #1020

merged 1 commit into from Mar 13, 2017


None yet
5 participants

lukasf commented Mar 9, 2017

Added the HamburgerVisibility property as discussed in #1019.

@@ -54,6 +54,7 @@

This comment has been minimized.


deltakosh Mar 9, 2017


I would call it HamburgerButtonVisibility to avoid misunderstandings

This comment has been minimized.


lukasf Mar 10, 2017


@deltakosh That was my first idea as well. But then I saw that all other properties of the hamburger button only have the "Hamburger" prefix (HamburgerHeight, HamburgerWidth, HamburgerMargin, they all affect the button and not the icon itself). So for having naming consistency, I chose to use "HamburgerVisibility". But I agree that HamburgerButtonVisibility is the better name. Shall I change it?

This comment has been minimized.


deltakosh Mar 10, 2017


You are completely right. We can keep like it then :)


Odonno approved these changes Mar 11, 2017

@IbraheemOsama IbraheemOsama merged commit 0670343 into windows-toolkit:dev Mar 13, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded

punker76 added a commit to MahApps/MahApps.Metro that referenced this pull request Mar 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment