Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preview pages on direct printing using PrintHelper #2855

Merged

Conversation

lucaasrojas
Copy link
Contributor

@lucaasrojas lucaasrojas commented Mar 11, 2019

Issue: #2835

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When trying to print without using direct print, the print task fails.

What is the new behavior?

Now the direct print works as well the preview pages visualization and the PDF printing.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

This PR also fixes issue #2773

@michael-hawker michael-hawker added this to the 5.1.1 milestone Mar 14, 2019
{
foreach (var element in _stateBags.Keys)
{
_stateBags[element].Restore(element);
}
_stateBags.Clear();

DetachCanvas();

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something odd here?

Helpers\PrintHelper\PrintHelper.cs(264,1): error SA1028: Code must not contain trailing whitespace [D:\a\1\s\Microsoft.Toolkit.Uwp\Microsoft.Toolkit.Uwp.csproj]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An unnecessary space. 😄

@michael-hawker
Copy link
Member

Sometimes, the images aren't loading:

image

But I don't have a consistent repo, I think the one time it was the first time (but then I'm not sure if I waited for the images to initially load into the sample), the next time I ran the app it was the 2nd. It may be stable after it occurs once... and I haven't gotten it to do it again.

Running debug build on RS5 without debugger attached.

Either way, it's working way better than it did, including the other scenarios!

I've tested this resolves #2773 as well.

@michael-hawker michael-hawker merged commit 2c1f255 into CommunityToolkit:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants