Skip to content

feat: support win x86#4

Closed
ArcticLampyrid wants to merge 2 commits into
windy1:masterfrom
ArcticLampyrid:master
Closed

feat: support win x86#4
ArcticLampyrid wants to merge 2 commits into
windy1:masterfrom
ArcticLampyrid:master

Conversation

@ArcticLampyrid

Copy link
Copy Markdown
Contributor
  1. Mark all extern functions as system abi, instead of marking them as stdcall abi on win x86 while c abi on other platform. Now it's more convenient to write platform-independent code for users.

extern "system" -- Usually the same as extern "C", except on Win32, in which case it's "stdcall", or what you should use to link to the Windows API itself (https://doc.rust-lang.org/reference/items/external-blocks.html)

  1. Import dll on win x86 correctly, fixing linkage errors.

@windy1 windy1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

Comment thread build.rs Outdated
@windy1 windy1 mentioned this pull request Jul 26, 2024
@windy1

windy1 commented Jul 26, 2024

Copy link
Copy Markdown
Owner

Superseded by: #5

@windy1 windy1 closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants