p2p2chのリファクタリングブランチのマージ #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* localdbパッケージへのDB処理の閉じ込め * ThreadクラスやResponsesクラスによる処理単位のオブジェクト化
Conflicts: app/controllers/Application.scala app/controllers/Subject.scala app/views/subject.scala.html build.sbt conf/routes project/plugins.sbt
added 7 commits
June 8, 2015 23:51
・stagingに上がっているキャッシュの削除 ・Scalaバージョンの修正 Viewのスクリプトを一時コメントアウト ScalazVersion = "7.1.1"
ScalaVersion = "2.10.4" ScalazVersion = "7.1.1" AkkaVersion = "2.2.3" Specs2Version = "3.1" play-testが古いバージョンのSpecs2を引っ張ってくる不具合を修正
アイエエエ！！スミマセン！！
scalazをimportしている部分を捜してみた DataFetchingBeacon.scala:L24
Subject.scala:L32など
Response.scala:L57など
正直scalazは不要です。ただ |
|
あー、Subject.scalaが読めなかったのはそのためか… |
|
尖った機能は使ってないのでたぶんバージョンは落とせます |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
とりあえずビルドが通ったバージョンをpull request。
機能的には元のp2p2chに戻ってしまいました。
ケジメ案件
ご参考
scalaz7.1とspecs2の2.4より前のversionおよびplay2.3以前のテストモジュールはバイナリ互換ないので同時に使えません
Scalazの歴史と概要
ぶっちゃけScalazを使う必要があるのか(´・ω・｀)？
Scalazを7.0.x系に直してやれば丸く収まるのではないかと思うが、コードの中身を見てないのでなんとも言えない。playが昔のspecs2を引っ張ってくるのもお節介すぎる。