Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wine-DXVK Integration #13

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@Guy1524
Copy link

commented Feb 20, 2019

This PR exists only to track all the commits combined.

@Guy1524 Guy1524 referenced this pull request Feb 20, 2019

Open

[WIP] DXVK as a native library for wine-integration #926

3 of 3 tasks complete
@leonmaxx

This comment has been minimized.

Copy link

commented Feb 21, 2019

Build error:

dxvk.c:383:5: error: 'for' loop initial declarations are only allowed in C99 mode
     for (unsigned int i = 0; SUCCEEDED( IDXGIAdapter_EnumOutputs(swapchain->adapter, i, output) ); i++)
     ^

Compiler: GCC 4.8.5 (CentOS 7.6)

@leonmaxx

This comment has been minimized.

Copy link

commented Feb 21, 2019

Apart from that builds ok.

@Guy1524

This comment has been minimized.

Copy link
Author

commented Feb 21, 2019

@leonmaxx Oddly enough, I don't get this error. Thanks for the heads up, fixing it now.

@leonmaxx

This comment has been minimized.

Copy link

commented Feb 22, 2019

@Guy1524 it shouldn't trigger on compilers where C99 is default standard for C.

@yurikoles

This comment has been minimized.

Copy link

commented Feb 24, 2019

@Guy1524 this is only a mirror, you need to send patches to wine-devel mailing list.

@yurikoles

This comment has been minimized.

Copy link

commented Feb 26, 2019

@yurikoles

This comment has been minimized.

Copy link

commented Feb 26, 2019

@Guy1524 please consider sending this to wine-staging

@leonmaxx

This comment has been minimized.

Copy link

commented Feb 26, 2019

@yurikoles Please, read first message:

This PR exists only to track all the commits combined.

@yurikoles

This comment has been minimized.

Copy link

commented Feb 26, 2019

@leonmaxx thanks for pointing me to this message, sorry for comments noise.

@Guy1524 had you followed this guide? https://wiki.winehq.org/Developer_Hints#Using_only_C89-compliant_code

@Guy1524

This comment has been minimized.

Copy link
Author

commented Feb 27, 2019

Update: That commit isn't broken, I just tested it on my laptop which had an issue.

@leonmaxx

This comment has been minimized.

Copy link

commented Feb 27, 2019

Build error:

In file included from dxvk.c:16:0:
/usr/include/dxvk/dxvk.h:32:62: error: unknown type name 'IDXGIVkSwapChain'
   typedef IDXGISwapChain1* (*PFN_dxvk_create_dxgi_swapchain)(IDXGIVkSwapChain *presenter, 
                                                              ^
/usr/include/dxvk/dxvk.h:45:7: error: unknown type name 'PFN_dxvk_create_dxgi_swapchain'
       PFN_dxvk_create_dxgi_swapchain  pfn_create_dxgi_swapchain;
       ^
make[1]: *** [dxvk.o] Error 1

Edit: this is w/o latest commit.

@Guy1524

This comment has been minimized.

Copy link
Author

commented Feb 27, 2019

@leonmaxx Looks like you picked a bad time to build, I changed the dxvk.h interface :P

@leonmaxx

This comment has been minimized.

Copy link

commented Feb 27, 2019

Sorry, I had to use latest libdxvk headers. Nevermind.

@Guy1524 Guy1524 force-pushed the Guy1524:wine-dxvk-integration branch from c1412d6 to 3abf6e5 Feb 27, 2019

@Guy1524 Guy1524 force-pushed the Guy1524:wine-dxvk-integration branch from 36bcd1a to eba58ed Mar 1, 2019

@yurikoles

This comment has been minimized.

Copy link

commented on e72f8bf Mar 8, 2019

Does 🍷 allows to use C++?

This comment has been minimized.

Copy link
Author

replied Mar 8, 2019

No, why do you ask?

@yurikoles

This comment has been minimized.

Copy link

commented on include/wine/winedxgi.idl in e72f8bf Mar 8, 2019

I mean that kind of lines.

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.