New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when ActiveRecord could not dump table. #147

Merged
merged 2 commits into from Aug 10, 2017

Conversation

3 participants
@k1LoW
Contributor

k1LoW commented Aug 10, 2017

When AR could not dump table, AR write error message in commnet out ( see https://github.com/rails/rails/blob/master/activerecord/lib/active_record/schema_dumper.rb#L162-L163 ).
But Ridgepole remove all comment out.

I fixed --export error message like following

$ bundle exec ridgepole -c database.yml --export -o Schemafile
Export Schema to `Schemafile`
[WARNING] Could not dump table "places" because of following StandardError
   Unknown type 'geometry' for column 'location'
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 10, 2017

Coverage Status

Coverage decreased (-0.2%) to 96.667% when pulling 12c6563 on k1LoW:show-warn-when-could-not-dump into 0bf8b96 on winebarrel:0.7.

coveralls commented Aug 10, 2017

Coverage Status

Coverage decreased (-0.2%) to 96.667% when pulling 12c6563 on k1LoW:show-warn-when-could-not-dump into 0bf8b96 on winebarrel:0.7.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 10, 2017

Coverage Status

Coverage increased (+0.01%) to 96.852% when pulling 23a630f on k1LoW:show-warn-when-could-not-dump into 0bf8b96 on winebarrel:0.7.

coveralls commented Aug 10, 2017

Coverage Status

Coverage increased (+0.01%) to 96.852% when pulling 23a630f on k1LoW:show-warn-when-could-not-dump into 0bf8b96 on winebarrel:0.7.

@winebarrel

This comment has been minimized.

Show comment
Hide comment
@winebarrel

winebarrel Aug 10, 2017

Owner

Thanks!

Owner

winebarrel commented Aug 10, 2017

Thanks!

@winebarrel winebarrel merged commit 87be62c into winebarrel:0.7 Aug 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 96.852%
Details
@winebarrel

This comment has been minimized.

Show comment
Hide comment
@winebarrel

winebarrel Aug 10, 2017

Owner

v0.7.1.beta2 has been released.

Owner

winebarrel commented Aug 10, 2017

v0.7.1.beta2 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment