New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v3.6.x (and above) download issues for Mac OSX, Windows #35

Merged
merged 3 commits into from Nov 30, 2018

Conversation

Projects
None yet
2 participants
@cantremember
Copy link

cantremember commented Oct 15, 2018

Fixes #33

  • 'osx' archive naming changed in v3.5
  • 'win32' archive naming changed in v3.5
  • not all signatures end with trailing whitespace
  • MongoDB site Downloads send folks to 'fastdl.mongodb.org'
  • added Test Suite for package/arch/version/os variants
  • TODOs for 'linux'; 'legacy', 'static', 'debian92', 'rhel57'
  • TypeScript development tooling w/ npm run build

negotiable: Test Suite coverage

to ensure that i produced a solution that really worked, i added an extensive data-driven Test Suite. it's great for proving out that the package works ... however it's a time sink and its scope of coverage could be reduced

feedback is welcome

negotiable: TODOs

i noticed the following 'operating system' namespaces when looking at all the download options for 'linux':

  • 'debian92' and 'rhel57', which are real OS versions for linux that aren't yet flushed out
  • 'legacy', which may or may not be related to the "using legacy release" notes in the current code
  • 'static', the meaning of which i do not know

i can remove any or all of those TODO comments from this commit, at your discretion

negotiable: TypeScript tooling

if you'd rather there wasn't an npm script and that the devDependencies didn't bring in tsc,
i will happily remove those changes

i could also break them off into a separate PR

did not run tsc

trying to merge the results of npm run build will likely reduce spurious conflicts -- probably not a good thing for the Reviewer

Dan Foley
Fix v3.6.x (and above) download issues for Mac OSX
#33

- 'osx' archive naming changed in v3.5
- 'win32' archive naming changed in v3.5
- not all signatures end with trailing whitespace
- MongoDB site Downloads send folks to 'fastdl.mongodb.org'
- added Test Suite for package/arch/version/os variants
- TODOs for 'linux'; 'legacy', 'static', 'debian92', 'rhel57'
- TypeScript development tooling w/ `npm run build`

@cantremember cantremember changed the title Fix v3.6.x (and above) download issues for Mac OSX Fix v3.6.x (and above) download issues for Mac OSX, Windows Oct 15, 2018

@LoneRifle
Copy link
Collaborator

LoneRifle left a comment

lgtm otherwise, thanks for the PR!

Show resolved Hide resolved src/mongodb-download.ts Outdated
@cantremember

This comment has been minimized.

Copy link

cantremember commented Nov 29, 2018

you are very welcome, @LoneRifle 👍

@LoneRifle

This comment has been minimized.

Copy link
Collaborator

LoneRifle commented Nov 30, 2018

I've not gotten the chance to test this on my machine, but once I do I'll merge to master and have one additional change to support Ubuntu 18 before kicking it out

@LoneRifle LoneRifle merged commit 9da8020 into winfinit:master Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment