New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show_in_html and show_in_iruby methods added #110

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@Shekharrajak

Shekharrajak commented Jun 7, 2017

Fixes #109

Now google_visualr is usable in IRuby notebook.

Just need to run this in IRuby notebook before plotting charts GoogleVisualr.init_iruby

@Shekharrajak

This comment has been minimized.

Show comment
Hide comment
@Shekharrajak

Shekharrajak Jun 7, 2017

I have added a example here : http://nbviewer.jupyter.org/github/Shekharrajak/google_visualr/blob/setup_for_iruby_notebook/lib/google_visualr/notebook_example/google_visualr_examples.ipynb

Ping @winston , please have a look in the PR. If google_visualr is usable in IRuby notebook then it will be very helpful for Ruby developers to see charts.

I have added a example here : http://nbviewer.jupyter.org/github/Shekharrajak/google_visualr/blob/setup_for_iruby_notebook/lib/google_visualr/notebook_example/google_visualr_examples.ipynb

Ping @winston , please have a look in the PR. If google_visualr is usable in IRuby notebook then it will be very helpful for Ruby developers to see charts.

@Shekharrajak

This comment has been minimized.

Show comment
Hide comment
@Shekharrajak

Shekharrajak Jun 7, 2017

if this PR is merged, then it will be very helpful for me to use it in Daru gem and plugin gem daru-view. So please try to review it as soon as possible.

if this PR is merged, then it will be very helpful for me to use it in Daru gem and plugin gem daru-view. So please try to review it as soon as possible.

@Shekharrajak

This comment has been minimized.

Show comment
Hide comment
@Shekharrajak

Shekharrajak Jun 7, 2017

I didn't understand the error msg : https://travis-ci.org/winston/google_visualr/jobs/240452702 , please let me know what is the traivs failure.

I didn't understand the error msg : https://travis-ci.org/winston/google_visualr/jobs/240452702 , please let me know what is the traivs failure.

@winston

This comment has been minimized.

Show comment
Hide comment
@winston

winston Jun 15, 2017

Owner

@Shekharrajak Apologies for the late reply as I am no longer actively maintaining this.

I took a look at your PR but I am wondering if this will add unnecessary bloat to the gem, given that most people won't be using this in the context of notebook.

Would it be better if you just fork this and maintain a fork of it just for notebook usage?

wdyt? Thanks!

Owner

winston commented Jun 15, 2017

@Shekharrajak Apologies for the late reply as I am no longer actively maintaining this.

I took a look at your PR but I am wondering if this will add unnecessary bloat to the gem, given that most people won't be using this in the context of notebook.

Would it be better if you just fork this and maintain a fork of it just for notebook usage?

wdyt? Thanks!

@Shekharrajak

This comment has been minimized.

Show comment
Hide comment
@Shekharrajak

Shekharrajak Jun 17, 2017

@winston , no problem. I think ruby developers uses IRuby notebook. It will be very easy if they see charts in notebook using small code. I will work on more and add this feature in my forked repo or directly in daru-view.

@winston , no problem. I think ruby developers uses IRuby notebook. It will be very easy if they see charts in notebook using small code. I will work on more and add this feature in my forked repo or directly in daru-view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment