Skip to content

Loading…

package.json should define test deps in `devDependencies` #8

Closed
isaacs opened this Issue · 4 comments

2 participants

@isaacs

Otherwise installing with npat turned on fails, because it can't find the test runner.

@indexzero
winstonjs member

What is npat?

@isaacs

It's cpants for npm :)

You can join the party now, if you want: npm config set npat true, and then installs will fail if tests fail. In a future release, it'll also upload test success/failure data to a server, so package authors can see where their stuff works and where it doesn't.

@indexzero
winstonjs member

These tests will fail anyway. Because the user needs to configure their own loggly account before running them. It's in the docs.

I feel like this npat thing (while nice) is pretty edge case. Maybe it should just look in both places?

@isaacs

If you install with --npat set, then it'll install devDependencies as well, since that's where test stuff usually goes.

The loggly tests exit successfully with a message on my machine if I install vows first. So, they "pass", albeit trivially.

@indexzero indexzero added a commit that closed this issue
@indexzero indexzero [dist] Update package.json, and .gitignore. Update require statements…
… to be more future proof. Fixes #8
2e92b49
@indexzero indexzero closed this in 2e92b49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.