Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Get the tests running and add travis-ci.org integration #2
Hey Guys, this is a small set of changes to get the tests running again.
When I tried to run the tests, the version of winston in the devDependences was too old ( 0.5.x ), and the node in the engines section was also too old (0.4.x).
I uprev'd winston to 0.5.x and engines.node to 0.8.x, which gets the tests running again. ( one failing ).
I added a travis.yml config file for travis-ci.org integration, and updated the README.md with the build-status badge. There would be a tiny amount of setup on your end to add this to your travis-ci repos.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
The issue here ends up being the circular metadata that eventually gets passed along to cradle, which attempts to JSON.stringify(... ) and blows up the stack with error events. I put up an annotated gist here :
The solution was to use the cycle module to normalize the metadata object. ( It's the same technique as used in winston here : https://github.com/flatiron/winston/blob/master/lib/winston/common.js )
With these changes, all of the tests pass.