Get the tests running and add travis-ci.org integration #2

Merged
merged 10 commits into from Dec 19, 2012

Conversation

Projects
None yet
2 participants
@kdawes
Contributor

kdawes commented Dec 6, 2012

Hey Guys, this is a small set of changes to get the tests running again.

When I tried to run the tests, the version of winston in the devDependences was too old ( 0.5.x ), and the node in the engines section was also too old (0.4.x).

https://gist.github.com/4173492

I uprev'd winston to 0.5.x and engines.node to 0.8.x, which gets the tests running again. ( one failing ).

https://gist.github.com/4221320

I added a travis.yml config file for travis-ci.org integration, and updated the README.md with the build-status badge. There would be a tiny amount of setup on your end to add this to your travis-ci repos.

@indexzero

This comment has been minimized.

Show comment Hide comment
@indexzero

indexzero Dec 6, 2012

Member

Why is the one test failing? That's a nasty bug; "stack overflow". Can you dig into it a little more before I merge this?

Member

indexzero commented Dec 6, 2012

Why is the one test failing? That's a nasty bug; "stack overflow". Can you dig into it a little more before I merge this?

@kdawes

This comment has been minimized.

Show comment Hide comment
@kdawes

kdawes Dec 6, 2012

Contributor

I will check it out .

Contributor

kdawes commented Dec 6, 2012

I will check it out .

@kdawes

This comment has been minimized.

Show comment Hide comment
@kdawes

kdawes Dec 7, 2012

Contributor

The issue here ends up being the circular metadata that eventually gets passed along to cradle, which attempts to JSON.stringify(... ) and blows up the stack with error events. I put up an annotated gist here :

https://gist.github.com/4228968

The solution was to use the cycle module to normalize the metadata object. ( It's the same technique as used in winston here : https://github.com/flatiron/winston/blob/master/lib/winston/common.js )

With these changes, all of the tests pass.

https://gist.github.com/4230312

Contributor

kdawes commented Dec 7, 2012

The issue here ends up being the circular metadata that eventually gets passed along to cradle, which attempts to JSON.stringify(... ) and blows up the stack with error events. I put up an annotated gist here :

https://gist.github.com/4228968

The solution was to use the cycle module to normalize the metadata object. ( It's the same technique as used in winston here : https://github.com/flatiron/winston/blob/master/lib/winston/common.js )

With these changes, all of the tests pass.

https://gist.github.com/4230312

@indexzero

This comment has been minimized.

Show comment Hide comment
@indexzero

indexzero Dec 19, 2012

Member

@kdawes Nice. Thanks for the follow-up!

Member

indexzero commented Dec 19, 2012

@kdawes Nice. Thanks for the follow-up!

indexzero added a commit that referenced this pull request Dec 19, 2012

Merge pull request #2 from kdawes/master
Get the tests running and add travis-ci.org integration

@indexzero indexzero merged commit 501d2d3 into winstonjs:master Dec 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment