New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check index params before drop #82

Merged

yurijmikhalevich merged 3 commits into winstonjs:master from Ijmir:check-index-params-before-drop

Dec 11, 2016

Contributor

Ijmir commented Nov 23, 2016

checking if index parameters have changed before dropping
index is created in background, otherwise it can hang the db (for large collection) until creation is finished

Ijmir added 2 commits

November 23, 2016 16:38


          drop timestamp index only when expireAfterSeconds changed

16d99b0


          create index in background

7c07307

Ijmir mentioned this pull request

index is being dropped without checking the existing index params first #83

Closed

yurijmikhalevich self-assigned this


          Merge branch 'master' into check-index-params-before-drop

47cfc5b

yurijmikhalevich merged commit 5506c26 into winstonjs:master

Member

yurijmikhalevich commented Dec 11, 2016

Hi. Thank you for the PR. Merged. Released as 2.0.5.

Btw, you forgot about returning db in the end of your function 47cfc5b...c11b08b#diff-1876e835f0fcae90facf5141326880b0R124 and haven't removed obsolete (after your patch) dropIndex error check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment