Remove `request` dependency #271

Closed
indexzero opened this Issue Jun 22, 2013 · 20 comments

Comments

Projects
None yet
8 participants
Owner

indexzero commented Jun 22, 2013

We only use 1% of the total request features so we should strip it down to something leaner.

Contributor

mmalecki commented Jun 22, 2013

Something like jsonquest?

mbilbille added a commit to mbilbille/winston that referenced this issue Mar 4, 2014

mbilbille added a commit to mbilbille/winston that referenced this issue Mar 4, 2014

Contributor

mbilbille commented Mar 4, 2014

Here is my PR: flatiron#369

Contributor

mbilbille commented Mar 6, 2014

@lisa-lionheart Did you reject my PR? Can you please give some explanation if this is the case. Thx.

Contributor

lisa-lionheart commented Mar 6, 2014

No, request was already removed and the travis configuration has been updated.

Just trying to do some house keeping and work through the backlog of issues here

Contributor

mbilbille commented Mar 6, 2014

@lisa-lionheart Glad to see this project back to life :)

Request is still mentionned in the package.json and used here: https://github.com/flatiron/winston/blob/f7ee20cffcdf1103d24e2ed29c64652d35a9364f/lib/winston/transports/http.js

Owner

indexzero commented Mar 7, 2014

@lisa-lionheart Seems that @mbilbille is technically correct unless there is a branch you're working on I'm not aware of. If so then please feel free to tell me to bugger off.

@indexzero indexzero reopened this Mar 7, 2014

Contributor

lisa-lionheart commented Mar 7, 2014

Request has been removed on branch develop, wish will be merged to master next release

Contributor

mbilbille commented Mar 7, 2014

Cool :) Thanks @lisa-lionheart

Owner

indexzero commented Mar 9, 2014

Ah ok. Got it. Thanks for pushing that up. I figured it was something like that.

Contributor

mbilbille commented Mar 27, 2014

@indexzero @lisa-lionheart Sorry to insist about this but why didn't you include this fix in 0.7.3 release?

Contributor

lisa-lionheart commented Mar 27, 2014

Well @indexzero told me not to commit changes to master, so I created a development branch. @indexzero needs to merge these changes to master and do another release

Contributor

mbilbille commented May 10, 2014

@indexzero any update on this issue?

Why is this issue closed? npm install winston currently fails because of where this dependency is locked. Here's the output from a greenfield install:

$ npm install winston --save --registry http://registry.npmjs.org
npm http GET http://registry.npmjs.org/winston
npm http 200 http://registry.npmjs.org/winston
npm http GET http://registry.npmjs.org/async
npm http GET http://registry.npmjs.org/colors
npm http GET http://registry.npmjs.org/cycle
npm http GET http://registry.npmjs.org/eyes
npm http GET http://registry.npmjs.org/pkginfo
npm http GET http://registry.npmjs.org/stack-trace
npm http GET http://registry.npmjs.org/request
npm http 304 http://registry.npmjs.org/pkginfo
npm http 200 http://registry.npmjs.org/cycle
npm http 304 http://registry.npmjs.org/eyes
npm http 200 http://registry.npmjs.org/colors
npm http 200 http://registry.npmjs.org/stack-trace
npm http 200 http://registry.npmjs.org/request
npm http 200 http://registry.npmjs.org/async
npm http GET http://registry.npmjs.org/form-data
npm http GET http://registry.npmjs.org/mime
npm http GET http://registry.npmjs.org/hawk
npm http GET http://registry.npmjs.org/node-uuid
npm http GET http://registry.npmjs.org/cookie-jar
npm http GET http://registry.npmjs.org/aws-sign
npm http GET http://registry.npmjs.org/oauth-sign
npm http GET http://registry.npmjs.org/forever-agent
npm http GET http://registry.npmjs.org/tunnel-agent
npm http GET http://registry.npmjs.org/json-stringify-safe
npm http GET http://registry.npmjs.org/qs
npm http 200 http://registry.npmjs.org/cookie-jar
npm http 200 http://registry.npmjs.org/node-uuid
npm http 304 http://registry.npmjs.org/hawk
npm ERR! notarget No compatible version found: hawk@'>=0.10.2-0 <0.11.0-0'
npm ERR! notarget Valid install targets:
npm ERR! notarget ["0.0.1","0.0.2","0.0.3","0.0.4","0.0.5","0.0.6","0.0.7","0.0.8","0.1.0","0.2.0","0.3.0","0.4.0","0.5.0","0.5.1","0.5.2","0.5.3","0.6.0","0.6.1","0.7.0","0.12.0","0.12.1","0.12.2","0.13.0","0.13.1","0.14.0","0.15.0","1.0.0","1.1.0-pre","1.1.1","1.1.2","2.0.0","2.1.0","2.1.1","2.1.2","2.1.3","2.2.0"]
npm ERR! notarget
npm ERR! notarget This is most likely not a problem with npm itself.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

npm ERR! System Darwin 13.1.0
npm ERR! command "/usr/local/Cellar/node/0.10.22/bin/node" "/usr/local/bin/npm" "install" "winston" "--save" "--registry" "http://registry.npmjs.org"
npm ERR! cwd /Users/ruppel/Documents/Scratch
npm ERR! node -v v0.10.22
npm ERR! npm -v 1.3.14
npm ERR! code ETARGET
npm http 200 http://registry.npmjs.org/mime
npm http 200 http://registry.npmjs.org/oauth-sign
npm http 200 http://registry.npmjs.org/aws-sign
npm http 304 http://registry.npmjs.org/forever-agent
npm http 200 http://registry.npmjs.org/form-data
npm http 200 http://registry.npmjs.org/tunnel-agent
npm http 304 http://registry.npmjs.org/json-stringify-safe
npm http 200 http://registry.npmjs.org/qs
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /Users/ruppel/Documents/Scratch/npm-debug.log
npm ERR! not ok code 0
Contributor

jcrugzz commented May 16, 2014

@jeremyruppel while the dep still does need to be removed, this is not the cause of your failure. Update your npm version (and you myswell update your node version as well) and run npm cache clean && npm i winston --save

@jcrugzz that did the trick, thanks!

Contributor

mbilbille commented Jun 2, 2014

@indexzero @lisa-lionheart Sorry to bother you guys, but this PR has been approved 3 month ago and these changes have not been merged to master. Could you please help?

The request dependency is interfering with some packaging that I'm doing:

groovebasin (1.1.0)
├─ ytdl (^0.2.8)
│  └─ cliff (~0.1.8)
│     ├─ winston (0.6.x)
│     │  ├─ request (2.16.x)

Can we get that branch merged into master and published?

Contributor

mbilbille commented Jun 27, 2014

+1

Member

pose commented Sep 3, 2014

👍. Any updates on this? Why is develop branch behind master? Is this project abandoned or looking for new maintainers?

Owner

indexzero commented Sep 3, 2014

@pose not abandoned, but definitely looking for new maintainers to help out closing issues and push the roadmap to 1.0. If you're interested please email me at charlie.robbins@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment