Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added simple colorize options #371

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

MichielDeMey commented Mar 9, 2014

Hi

We've added a couple of more choices for the colorize option:

  • 'level', which will only colorize the level (same as true)
  • 'message', which will only colorize the message
  • 'all', which will colorize both the level and the message

The default behavior is kept, simply set colorize to true to colorize the level only, set it to false to disable colors.

Owner

indexzero commented Sep 23, 2014

Thank you for your contribution. This is much cleaner than #363. Will go into winston@0.9.0 Also worth noting that this option will be dropped in winston@1.0.0 in favor of custom Formatters.

Owner

indexzero commented Jan 6, 2015

Finally got this cherry-picked & squashed onto master. In the future you should check out git rebase -i, it will make your git history a lot cleaner 👍

@indexzero indexzero closed this Jan 6, 2015

Contributor

adius commented Feb 5, 2015

Maybe next time you can also update the documentation. Just spend half an hour wondering why colorize: 'true' doesn't work.

Contributor

adius commented Feb 5, 2015

Ah colorize: true still works, but colorize: 'true' was wrong all along.
Pull request for fixing this: #547

Contributor

MichielDeMey commented Feb 5, 2015

Nice catch! 👍

Please update the README file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment