Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preshutdown support #614

Merged
merged 1 commit into from Jul 30, 2020
Merged

Preshutdown support #614

merged 1 commit into from Jul 30, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Jul 30, 2020

Fixes #489

The Event Log service is available during the preshutdown period.

TODO: Track dotnet/runtime#30386.

@nxtn nxtn added this to the 3.x milestone Jul 30, 2020
@nxtn nxtn requested a review from oleg-nenashev as a code owner July 30, 2020 06:23
@nxtn nxtn linked an issue Jul 30, 2020 that may be closed by this pull request
@nxtn nxtn merged commit c3771e3 into winsw:v3 Jul 30, 2020
@nxtn nxtn deleted the v3-preshutdown branch July 30, 2020 06:29
@nxtn
Copy link
Contributor Author

nxtn commented Aug 1, 2020

I sometimes saw a "service did not shutdown properly after receiving a preshutdown control" error. Couldn't figure out why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Giving the service more time to stop when Windows restarts
1 participant