From c5c775e38d9e145d580cf4f7cebacf605bd7ffea Mon Sep 17 00:00:00 2001
From: winton <mail@wintoni.us>
Date: Sat, 5 Dec 2009 23:39:00 -0800
Subject: [PATCH] Specs passing with newly modularized structure and config
 system

---
 lib/lilypad.rb                            |  50 +++++++
 lib/lilypad/adapters/rails.rb             |  23 ++++
 lib/lilypad/adapters/sinatra.rb           |  10 ++
 lib/lilypad/config.rb                     |  63 +++++++++
 lib/lilypad/config/request.rb             |  24 ++++
 lib/lilypad/hoptoad/deploy.rb             |  42 ++++++
 lib/lilypad/hoptoad/notify.rb             |  83 ++++++++++++
 lib/lilypad/hoptoad/xml.rb                |  61 +++++++++
 lib/lilypad/log.rb                        |  46 +++++++
 lib/rack/lilypad.rb                       | 152 ++--------------------
 lib/rack/lilypad/rails.rb                 |  27 ----
 spec/fixtures/rails/config/environment.rb |   4 +-
 spec/fixtures/sinatra.rb                  |   9 +-
 spec/{rack => }/lilypad_spec.rb           |  49 ++++---
 spec/spec_helper.rb                       |   4 +-
 15 files changed, 454 insertions(+), 193 deletions(-)
 create mode 100644 lib/lilypad.rb
 create mode 100644 lib/lilypad/adapters/rails.rb
 create mode 100644 lib/lilypad/adapters/sinatra.rb
 create mode 100644 lib/lilypad/config.rb
 create mode 100644 lib/lilypad/config/request.rb
 create mode 100644 lib/lilypad/hoptoad/deploy.rb
 create mode 100644 lib/lilypad/hoptoad/notify.rb
 create mode 100644 lib/lilypad/hoptoad/xml.rb
 create mode 100644 lib/lilypad/log.rb
 delete mode 100644 lib/rack/lilypad/rails.rb
 rename spec/{rack => }/lilypad_spec.rb (72%)

diff --git a/lib/lilypad.rb b/lib/lilypad.rb
new file mode 100644
index 0000000..aac5c7e
--- /dev/null
+++ b/lib/lilypad.rb
@@ -0,0 +1,50 @@
+require 'builder'
+require 'net/http'
+require 'rack'
+
+lib = File.dirname(__FILE__)
+require "#{lib}/lilypad/config"
+require "#{lib}/lilypad/config/request"
+require "#{lib}/lilypad/log"
+require "#{lib}/lilypad/hoptoad/deploy"
+require "#{lib}/lilypad/hoptoad/notify"
+require "#{lib}/lilypad/hoptoad/xml"
+require "#{lib}/rack/lilypad"
+
+class Lilypad
+  class <<self
+    
+    def active?
+      Config.api_key
+    end
+    
+    def config(api_key=nil, &block)
+      if api_key
+        Config.api_key api_key
+      end
+      if block_given?
+        Config.class_eval &block
+      end
+    end
+    
+    def deploy(options)
+      if active? && production?
+        Hoptoad::Deploy.new options
+      end
+    end
+    
+    def notify(exception, env=nil)
+      if active? && production?
+        Hoptoad::Notify.new env, exception
+      end
+    end
+    
+    def production?
+      Config.environments.include? ENV['RACK_ENV']
+    end
+  end
+end
+
+def Lilypad(api_key=nil, &block)
+  Lilypad.config api_key, &block
+end
\ No newline at end of file
diff --git a/lib/lilypad/adapters/rails.rb b/lib/lilypad/adapters/rails.rb
new file mode 100644
index 0000000..3ef3992
--- /dev/null
+++ b/lib/lilypad/adapters/rails.rb
@@ -0,0 +1,23 @@
+class Lilypad
+  module Rails
+    
+    def self.included(base)
+      ENV['RACK_ENV'] = ENV['RAILS_ENV']
+      base.send(:include, LilypadMethods) if Lilypad.production?
+    end
+    
+    module LilypadMethods
+      
+      private
+      
+      def rescue_action_without_handler(exception)
+        super
+        Config::Request.action params[:action]
+        Config::Request.component params[:controller]
+        raise exception
+      end
+    end
+  end
+end
+
+ActionController::Base.send(:include, Lilypad::Rails)
\ No newline at end of file
diff --git a/lib/lilypad/adapters/sinatra.rb b/lib/lilypad/adapters/sinatra.rb
new file mode 100644
index 0000000..14cf85b
--- /dev/null
+++ b/lib/lilypad/adapters/sinatra.rb
@@ -0,0 +1,10 @@
+class Lilypad
+  module Sinatra
+    
+    def self.included(base)
+      base.set(:raise_errors, true) if Lilypad.production?
+    end
+  end
+end
+
+Sinatra::Base.send(:include, Lilypad::Sinatra)
\ No newline at end of file
diff --git a/lib/lilypad/config.rb b/lib/lilypad/config.rb
new file mode 100644
index 0000000..6faf31c
--- /dev/null
+++ b/lib/lilypad/config.rb
@@ -0,0 +1,63 @@
+class Lilypad
+  class Config
+    class <<self
+      
+      def api_key(api_key=nil, &block)
+        @api_key = api_key unless api_key.nil?
+        @api_key_block = block if block_given?
+        @api_key || @api_key_block
+      end
+      
+      def deploy_url(url=nil)
+        @deploy_url = url unless url.nil?
+        @deploy_url || "http://hoptoadapp.com/deploys.txt"
+      end
+      
+      def environments(environments=nil)
+        @environments = environments unless environments.nil?
+        @environments || %w(production staging)
+      end
+      
+      def filters(filters=nil)
+        @filters = filters unless filters.nil?
+        @filters
+      end
+      
+      def log(log=nil)
+        @log = log unless log.nil?
+        @log
+      end
+      
+      def notify_url(url=nil)
+        @notify_url = url unless url.nil?
+        @url || "http://hoptoadapp.com:80/notify_url/v2/notices"
+      end
+      
+      def rails
+        require "#{File.dirname(__FILE__)}/adapters/rails"
+      end
+      
+      def reset!
+        self.instance_variables.each do |name|
+          eval "#{name} = nil"
+        end
+      end
+      
+      def sinatra
+        require "#{File.dirname(__FILE__)}/adapters/sinatra"
+      end
+      
+    end
+    
+    module Methods
+      
+      def api_key(env=nil, exception=nil)
+        if Config.api_key.respond_to?(:call)
+          Config.api_key.call env, exception
+        else
+          Config.api_key
+        end
+      end
+    end
+  end
+end
\ No newline at end of file
diff --git a/lib/lilypad/config/request.rb b/lib/lilypad/config/request.rb
new file mode 100644
index 0000000..056f06e
--- /dev/null
+++ b/lib/lilypad/config/request.rb
@@ -0,0 +1,24 @@
+class Lilypad
+  class Config
+    class Request
+      class <<self
+        
+        def action(action=nil)
+          @action = action unless action.nil?
+          @action
+        end
+        
+        def component(component=nil)
+          @component = component unless component.nil?
+          @component
+        end
+        
+        def reset!
+          self.instance_variables.each do |name|
+            eval "#{name} = nil"
+          end
+        end
+      end
+    end
+  end
+end
\ No newline at end of file
diff --git a/lib/lilypad/hoptoad/deploy.rb b/lib/lilypad/hoptoad/deploy.rb
new file mode 100644
index 0000000..69a0afd
--- /dev/null
+++ b/lib/lilypad/hoptoad/deploy.rb
@@ -0,0 +1,42 @@
+class Lilypad
+  class Hoptoad
+    class Deploy
+      
+      include Config::Methods
+      include Log::Methods
+      
+      def initialize(options)
+        @options = options
+        
+        begin
+          post
+        rescue Exception => e
+        end
+        
+        log :debug, @response
+        success?
+      end
+      
+      private
+      
+      def params
+        {
+          'api_key' => api_key,
+          'deploy[local_username]' => @options[:username],
+          'deploy[rails_env]' => @options[:environment],
+          'deploy[scm_revision]' => @options[:revision],
+          'deploy[scm_repository]' => @options[:repository]
+        }
+      end
+      
+      def post
+        url = URI.parse Config.deploy_url
+        @response = Net::HTTP.post_form url, params
+      end
+      
+      def success?
+        @response.class.superclass == Net::HTTPSuccess
+      end
+    end
+  end
+end
\ No newline at end of file
diff --git a/lib/lilypad/hoptoad/notify.rb b/lib/lilypad/hoptoad/notify.rb
new file mode 100644
index 0000000..238d17d
--- /dev/null
+++ b/lib/lilypad/hoptoad/notify.rb
@@ -0,0 +1,83 @@
+class Lilypad
+  class Hoptoad
+    class Notify
+      
+      include Log::Methods
+      
+      def initialize(env, exception)
+        @exception = exception
+        @env = env
+        
+        http_start do |http|
+          begin
+            xml = XML.build *parse
+            http.post @uri.path, xml, headers
+          rescue Exception => e
+          end
+        end
+        
+        if env && success?
+          env['hoptoad.notified'] = true
+        end
+        
+        Config::Request.reset!
+        log :notify, @response
+        success?
+      end
+      
+      private
+      
+      def backtrace
+        regex = %r{^([^:]+):(\d+)(?::in `([^']+)')?$}
+        @exception.backtrace.map do |line|
+          _, file, number, method = line.match(regex).to_a
+          Backtrace.new file, number, method
+        end
+      end
+
+      def filter(hash)
+        return unless Config.filters
+        hash.inject({}) do |acc, (key, val)|
+          match = Config.filters.any? { |f| key.to_s =~ Regexp.new(f) }
+          acc[key] = match ? "[FILTERED]" : val
+          acc
+        end
+      end
+      
+      def headers
+        {
+          'Content-type' => 'text/xml',
+          'Accept' => 'text/xml, application/xml'
+        }
+      end
+      
+      def http_start(&block)
+        @uri = URI.parse Config.notify_url
+        Net::HTTP.start @uri.host, @uri.port do |http|
+          http.read_timeout = 5 # seconds
+          http.open_timeout = 2 # seconds
+          @response = yield http
+        end
+      end
+
+      def parse
+        env = filter ENV.to_hash.merge(@env || {})
+        if @env
+          request = Rack::Request.new @env
+          request_path = request.script_name + request.path_info
+        else
+          request = nil
+          request_path = 'Internal'
+        end
+        [ backtrace, env, @exception, request, request_path ]
+      end
+      
+      def success?
+        @response.class.superclass == Net::HTTPSuccess
+      end
+      
+      class Backtrace < Struct.new(:file, :number, :method)
+      end
+    end
+  end
+end
\ No newline at end of file
diff --git a/lib/lilypad/hoptoad/xml.rb b/lib/lilypad/hoptoad/xml.rb
new file mode 100644
index 0000000..8e97b43
--- /dev/null
+++ b/lib/lilypad/hoptoad/xml.rb
@@ -0,0 +1,61 @@
+class Lilypad
+  class Hoptoad
+    class XML
+      class <<self
+        
+        include Config::Methods
+        
+        def build(backtrace, env, exception, request, request_path)
+          @@last_request = nil
+          xml = ::Builder::XmlMarkup.new
+          xml.instruct! :xml, :version => "1.0", :encoding => "UTF-8"
+          xml.notice :version => '2.0.0' do |n|
+            n.tag! 'api-key', api_key
+            n.notifier do |n|
+              n.name 'Lilypad'
+              n.url 'http://github.com/winton/lilypad'
+              n.version '0.2.4'
+            end
+            n.error do |e|
+              e.tag! 'class', exception.class.name
+              e.message exception.message
+              e.backtrace do |b|
+                backtrace.each do |line|
+                  b.line :method => line.method, :file => line.file, :number => line.number
+                end
+              end
+            end
+            n.request do |r|
+              r.action Config::Request.action
+              r.component Config::Request.component || request_path
+              r.url request_path
+              if request && request.params.any?
+                r.params do |p|
+                  request.params.each do |key, value|
+                    p.var value.to_s, :key => key
+                  end
+                end
+              end
+              if env.any?
+                r.tag! 'cgi-data' do |c|
+                  env.each do |key, value|
+                    c.var value.to_s, :key => key
+                  end
+                end
+              end
+            end
+            n.tag! 'server-environment' do |s|
+              s.tag! 'project-root', Dir.pwd
+              s.tag! 'environment-name', ENV['RACK_ENV'] || 'development'
+            end
+          end
+          @@last_request = xml.target!
+        end
+        
+        def last_request
+          @@last_request
+        end
+      end
+    end
+  end
+end
\ No newline at end of file
diff --git a/lib/lilypad/log.rb b/lib/lilypad/log.rb
new file mode 100644
index 0000000..0fa36b6
--- /dev/null
+++ b/lib/lilypad/log.rb
@@ -0,0 +1,46 @@
+class Lilypad
+  class Log
+    
+    def initialize(type, response)
+      @response = response
+      @type = type
+      self.class.log title, xml_request, response_body
+    end
+    
+    class <<self
+
+      def log(*lines)
+        ::File.open Config.log, 'a' do |f|
+          f.write lines.compact.join("\n\n") + "\n\n"
+        end
+      end
+    end
+    
+    module Methods
+      
+      def log(type, response)
+        if Config.log
+          Log.new type, response
+        end
+      end
+    end
+    
+    private
+    
+    def response_body
+      @response.body rescue nil
+    end
+    
+    def success?
+      @response.class.superclass == Net::HTTPSuccess
+    end
+    
+    def title
+      "#{@type.to_s.capitalize} #{success? ? 'Success' : 'Failure'}:"
+    end
+    
+    def xml_request
+      Hoptoad::XML.last_request
+    end
+  end
+end
\ No newline at end of file
diff --git a/lib/rack/lilypad.rb b/lib/rack/lilypad.rb
index ac9a1b0..1074bcc 100644
--- a/lib/rack/lilypad.rb
+++ b/lib/rack/lilypad.rb
@@ -1,161 +1,25 @@
-require 'builder'
-require 'net/http'
-require 'rack'
-
 module Rack
   class Lilypad
     
-    attr_accessor :filters
-    attr_accessor :log
-
-    def initialize(app, api_key = nil)
+    def initialize(app, api_key=nil, &block)
       @app = app
-      @filters = []
-      @log = false
-      yield self if block_given?
-      @filters.flatten!
-      @@hoptoad = @hoptoad = Hoptoad.new(api_key, @filters, @log)
+      Lilypad api_key, &block
     end
-
+    
     def call(env)
       status, headers, body =
         begin
-          @app.call(env)
+          @app.call env
         rescue Exception => e
-          @hoptoad.post(e, env)
+          ::Lilypad.notify e, env
           raise
         end
-      @hoptoad.post(env['rack.exception'], env) if env['rack.exception']
-      [ status, headers, body ]
-    end
-    
-    class <<self
-      
-      def notify(e)
-        @@hoptoad.post(e)
-      end
-      
-      def production?
-        %w(staging production).include?(ENV['RACK_ENV'])
-      end
-    end
-
-    class Hoptoad
-      
-      def initialize(api_key, filters=[], log=false)
-        @api_key = api_key
-        @filters = filters
-        @log = log
-      end
-      
-      def backtrace(exception)
-        regex = %r{^([^:]+):(\d+)(?::in `([^']+)')?$}
-        exception.backtrace.map do |line|
-          _, file, number, method = line.match(regex).to_a
-          Backtrace.new(file, number, method)
-        end
-      end
-      
-      def filter(hash)
-        hash.inject({}) do |acc, (key, val)|
-          acc[key] = @filters.any? { |f| key.to_s =~ Regexp.new(f) } ? "[FILTERED]" : val
-          acc
-        end
-      end
-      
-      def log(*msg)
-        msg = msg.compact.join("\n\n") + "\n\n"
-        ::File.open(@log, 'a') { |f| f.write(msg) } if @log
-      end
-      
-      def post(exception, env=nil)
-        return unless Lilypad.production?
-        uri = URI.parse("http://hoptoadapp.com:80/notifier_api/v2/notices")
-        Net::HTTP.start(uri.host, uri.port) do |http|
-          headers = {
-            'Content-type' => 'text/xml',
-            'Accept' => 'text/xml, application/xml'
-          }
-          http.read_timeout = 5 # seconds
-          http.open_timeout = 2 # seconds
-          response = begin
-            http.post uri.path, xml(exception, env), headers
-          rescue TimeoutError => e
-          end
-          case response
-          when Net::HTTPSuccess
-            env['hoptoad.notified'] = true if env
-            log "Hoptoad Success: #{response.class}"
-          else
-            log "Hoptoad Failure:", (response.body rescue nil), @@last_request
-          end
-        end
-      end
       
-      def xml(exception, env)
-        environment = filter(ENV.to_hash.merge(env || {}))
-        if env
-          request = Rack::Request.new(env)
-          request_path = request.script_name + request.path_info
-        else
-          request = nil
-          request_path = 'internal'
-        end
-        
-        xml = ::Builder::XmlMarkup.new
-        xml.instruct! :xml, :version => "1.0", :encoding => "UTF-8"
-        xml.notice(:version => '2.0.0') do |n|
-          n.tag! 'api-key', @api_key
-          n.notifier do |n|
-            n.name 'Lilypad'
-            n.url 'http://github.com/winton/lilypad'
-            n.version '0.1.7'
-          end
-          n.error do |e|
-            e.tag! 'class', exception.class.name
-            e.message exception.message
-            e.backtrace do |b|
-              backtrace(exception).each do |line|
-                b.line(:method => line.method, :file => line.file, :number => line.number)
-              end
-            end
-          end
-          n.request do |r|
-            r.action environment['rack.lilypad.action']
-            r.component environment['rack.lilypad.component'] || request_path
-            r.url request_path
-            if request && request.params.any?
-              r.params do |p|
-                request.params.each do |key, value|
-                  p.var(value.to_s, :key => key)
-                end
-              end
-            end
-            if environment.any?
-              r.tag!('cgi-data') do |c|
-                environment.each do |key, value|
-                  c.var(value.to_s, :key => key)
-                end
-              end
-            end
-          end
-          n.tag!('server-environment') do |s|
-            s.tag! 'project-root', Dir.pwd
-            s.tag! 'environment-name', ENV['RACK_ENV'] || 'development'
-          end
-        end
-        @@last_request = xml.target!
+      if env['rack.exception']
+        ::Lilypad.notify env['rack.exception'], env
       end
       
-      class <<self
-        
-        def last_request
-          @@last_request
-        end
-      end
-
-      class Backtrace < Struct.new(:file, :number, :method)
-      end
+      [ status, headers, body ]
     end
   end
 end
\ No newline at end of file
diff --git a/lib/rack/lilypad/rails.rb b/lib/rack/lilypad/rails.rb
deleted file mode 100644
index 880b0ff..0000000
--- a/lib/rack/lilypad/rails.rb
+++ /dev/null
@@ -1,27 +0,0 @@
-require 'rack/lilypad'
-
-module Rack
-  class Lilypad
-    module Rails
-      
-      def self.included(base)
-        ENV['RACK_ENV'] = ENV['RAILS_ENV']
-        base.send(:include, LilypadMethods) if Lilypad.production?
-      end
-      
-      module LilypadMethods
-        
-        private
-        
-        def rescue_action_without_handler(exception)
-          super
-          request.env['rack.lilypad.component'] = params[:controller]
-          request.env['rack.lilypad.action'] = params[:action]
-          raise exception
-        end
-      end
-    end
-  end
-end
-
-ActionController::Base.send(:include, Rack::Lilypad::Rails)
\ No newline at end of file
diff --git a/spec/fixtures/rails/config/environment.rb b/spec/fixtures/rails/config/environment.rb
index b52455f..a3b999f 100644
--- a/spec/fixtures/rails/config/environment.rb
+++ b/spec/fixtures/rails/config/environment.rb
@@ -39,9 +39,9 @@
   # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}')]
   # config.i18n.default_locale = :de
   
-  config.middleware.insert_after(ActionController::Failsafe, Rack::Lilypad, 'xxx')
+  config.middleware.insert_after(ActionController::Failsafe, Rack::Lilypad, '')
   config.middleware.delete(ActionController::Failsafe) # Enabling this magically makes all the specs pass! :)
   config.middleware.use(TestExceptionMiddleware)
 end
 
-require 'rack/lilypad/rails'
\ No newline at end of file
+Lilypad { rails }
\ No newline at end of file
diff --git a/spec/fixtures/sinatra.rb b/spec/fixtures/sinatra.rb
index adb7dd5..a4c083c 100644
--- a/spec/fixtures/sinatra.rb
+++ b/spec/fixtures/sinatra.rb
@@ -1,6 +1,13 @@
+Sinatra::Base.class_eval do
+  # Make sure the Sinatra adapter does its job
+  set :raise_errors, false
+end
+
 class SinatraApp < Sinatra::Base
   
-  use Rack::Lilypad, 'xxx'
+  use Rack::Lilypad, '' do
+    sinatra
+  end
   use TestExceptionMiddleware
   
   get "/nothing" do
diff --git a/spec/rack/lilypad_spec.rb b/spec/lilypad_spec.rb
similarity index 72%
rename from spec/rack/lilypad_spec.rb
rename to spec/lilypad_spec.rb
index d683cfc..0011d6e 100644
--- a/spec/rack/lilypad_spec.rb
+++ b/spec/lilypad_spec.rb
@@ -1,4 +1,4 @@
-require File.expand_path("#{File.dirname(__FILE__)}/../spec_helper")
+require "#{File.dirname(__FILE__)}/spec_helper"
 
 describe Rack::Lilypad do
 
@@ -15,33 +15,38 @@
   end
   
   it "should yield a configuration object to the block when created" do
-    notifier = Rack::Lilypad.new(@app, '') do |app|
-      app.filters << %w(T1 T2)
-      app.log = 'T3'
+    Rack::Lilypad.new(@app, '') do
+      filters %w(T1 T2)
+      log 'T3'
     end
-    notifier.filters.include?('T1').should == true
-    notifier.filters.include?('T2').should == true
-    notifier.log.should == 'T3'
+    Lilypad::Config.filters.include?('T1').should == true
+    Lilypad::Config.filters.include?('T2').should == true
+    Lilypad::Config.log.should == 'T3'
+    
+    Lilypad::Config.filters []
+    Lilypad::Config.log false
   end
   
   it "should write to a log file on success and failure" do
-    log = "#{SPEC}/fixtures/hoptoad.log"
+    log_path = "#{SPEC}/fixtures/hoptoad.log"
     notifier = Rack::Lilypad.new(@app, '') do |app|
-      app.log = log
+      log log_path
     end
     
     notifier.call(@env) rescue nil
     
-    File.exists?(log).should == true
-    File.read(log).should =~ /Hoptoad Success/
-    File.delete(log)
+    File.exists?(log_path).should == true
+    File.read(log_path).should =~ /Notify Success/
+    File.delete(log_path)
     
     @http.stub!(:post).and_return false
     notifier.call(@env) rescue nil
     
-    File.exists?(log).should == true
-    File.read(log).should =~ /Hoptoad Failure/
-    File.delete(log)
+    File.exists?(log_path).should == true
+    File.read(log_path).should =~ /Notify Failure/
+    File.delete(log_path)
+    
+    Lilypad::Config.log false
   end
   
   it "should transfer valid XML to Hoptoad" do
@@ -54,16 +59,26 @@
     validate_xml
   end
   
-  it "should allow direct access to the post method" do
+  it "should provide a notify method" do
     @http.should_receive(:post)
     begin
       raise TestError, 'Test'
     rescue Exception => e
-      Rack::Lilypad.notify(e)
+      Lilypad.notify(e)
     end
     validate_xml
   end
   
+  it "should provide a deploy method" do
+    Net::HTTP.should_receive(:post_form).and_return(Net::HTTPOK.new(nil, nil, nil))
+    Lilypad.deploy(
+      :username => 't1',
+      :environment => 't2',
+      :revision => 't3',
+      :repository => 't4'
+    )
+  end
+  
   describe 'Rails' do
     
     def app
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index 419a225..e3d1923 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -2,7 +2,7 @@
 SPEC = File.dirname(__FILE__)
 $:.unshift File.expand_path("#{SPEC}/../lib")
 
-require 'rack/lilypad'
+require 'lilypad'
 require 'pp'
 
 require 'rubygems'
@@ -29,7 +29,7 @@ def debug(object)
 
 def validate_xml
   xsd = Nokogiri::XML::Schema(File.read(SPEC + '/fixtures/hoptoad_2_0.xsd'))
-  doc = Nokogiri::XML(Rack::Lilypad::Hoptoad.last_request)
+  doc = Nokogiri::XML(Lilypad::Hoptoad::XML.last_request)
   
   errors = xsd.validate(doc)
   errors.each do |error|