New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add read the docs configuration #46
Conversation
This pull request addresses issues #13 |
# for example take major/minor | ||
version = '.'.join(release.split('.')[:2]) | ||
from setuptools_scm import get_version | ||
version = release = get_version(root='..') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, setuptools_scm is very convenient!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, though strictly speaking this change is against their usage advice. See the section “Usage from Sphinx” here: https://github.com/pypa/setuptools_scm/blob/master/README.rst
The problem is that we are not either doing an editable or real install with pip as the Confluent Kafka package must be built and that doesn’t work cleanly on RTD (this should also help explain why the Kafka related modules are mocked above).
Nice! Is this visible already somewhere? That travis error on nighly python 3.7
might be because Edit: See more here: confluentinc/confluent-kafka-python#21 |
I'll merge this now. As noted by @ah- on confluentinc/confluent-kafka-python#21 the Python nightly failure is due to a planned Python language change in 3.7. We will move to using asynchronous keyword arg when available in confluent kafka Python release. PEP 492 transition plan for await/async to become full keywords: https://www.python.org/dev/peps/pep-0492/#deprecation-plans Recent CPython pull request implementing this: |
Documentation for latest (i.e. master) build now available here: http://winton-kafka-streams.readthedocs.io/en/latest/ |
A few warnings in the output that ought to be cleaned up but nothing too serious. Can be done as part of pull request to actually write some reasonable documentation - currently this just outputs an API reference section.