New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add tray icon resolutions #1676
Conversation
electron/js/menu/TrayHandler.js
Outdated
this.lastUnreadCount = 0; | ||
} | ||
|
||
initTray(hasOverlaySupport, trayIcon = new Tray(nativeImage.createEmpty())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why moving this part to another method? This creates temporal coupling (the consumer now has to call the methods in the right order else he will have unexpected behaviors)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want the consumer to decide if he/she wants to have a tray icon or not. That's why it got decoupled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very valid point!
Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
icons scaling probably does not work in Cinnamon (Manjaro Linux). The default |
No description provided.