Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove grunt #2354

Merged
merged 26 commits into from Apr 5, 2019
Merged

refactor: Remove grunt #2354

merged 26 commits into from Apr 5, 2019

Conversation

ffflorian
Copy link
Contributor

@ffflorian ffflorian commented Mar 18, 2019 •
edited

Breaking changes:

  • all builds are now in wrap/dist (instead of wrap/prod, wrap/internal, ...)
  • info.json is now wire.json
  • BUILD_ENV is now APP_ENV

@ffflorian ffflorian force-pushed the chore/goodbye-grunt branch 2 times, most recently from 9a1d829 to d2ab630 Compare March 18, 2019 16:30
@ffflorian ffflorian marked this pull request as ready for review March 19, 2019 10:27
@ffflorian ffflorian changed the title chore: Remove grunt refactor: Remove grunt Mar 26, 2019
bennycode
bennycode approved these changes Apr 5, 2019
View reviewed changes
electron/src/settings/config.ts Outdated Show resolved Hide resolved
atomrc
atomrc reviewed Apr 5, 2019
View reviewed changes
electron/wire.json
"environment": "internal",
"legalUrl": "https://wire.com/legal/",
"licensesUrl": "https://wire.com/legal/licenses/",
"maximumAccounts": "3",
Copy link
Contributor

@atomrc atomrc Apr 5, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this as a number instead of a string

Suggested change
"maximumAccounts": "3",
"maximumAccounts": 3,

Copy link
Contributor Author

@ffflorian ffflorian Apr 5, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it will be replaced with a string when loading a configuration via process.env, I figured we should save it as a string here, too.

@ffflorian ffflorian merged commit 0752e94 into staging Apr 5, 2019
@ffflorian ffflorian deleted the chore/goodbye-grunt branch April 5, 2019 15:15
@ffflorian ffflorian mentioned this pull request Apr 9, 2019
Closed
@ffflorian ffflorian mentioned this pull request Apr 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennycode bennycode bennycode approved these changes

@atomrc atomrc atomrc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ffflorian @bennycode @atomrc