Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIOS-11452: Process legal hold hint flag when receiving message #734

Merged
merged 6 commits into from Jun 7, 2019

Conversation

Projects
None yet
4 participants
@alexaubry
Copy link
Contributor

commented Jun 7, 2019

What's new in this PR?

Issues

We added support for legal hold flags in messages in #731. We now need to process this flag when receiving a message to update the legal hold status in the conversation.

Solutions

  • Update the message content protocol to conditionally return the status, only if it's set in the protobuf
  • Add a method on the conversation to update the status based on the hint and current status
  • Update the OTR message downstream creation method to call the method mentioned above before inserting the message

alexaubry added some commits Jun 7, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 7, 2019

Codecov Report

Merging #734 into develop will increase coverage by 0.19%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           develop    #734      +/-   ##
==========================================
+ Coverage     83.9%   84.1%   +0.19%     
==========================================
  Files          200     200              
  Lines        13797   13856      +59     
==========================================
+ Hits         11577   11654      +77     
+ Misses        2220    2202      -18
@typfel

typfel approved these changes Jun 7, 2019

@alexaubry

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

@zenkins release major

@wire-bot wire-bot merged commit aedcf7d into develop Jun 7, 2019

1 of 4 checks passed

wire-ios-data-model Build #20190607.3 failed
Details
wire-ios-data-model (Test)
Details
jenkins/merge-pr Build started for merge commit.
Details
license/cla Contributor License Agreement is signed.
Details

@wire-bot wire-bot deleted the feature/handle-lh-flag branch Jun 7, 2019

zenkins pushed a commit that referenced this pull request Jun 7, 2019

Release 176.0.0
Diff with previous:
175.1.1...176.0.0

Commit  | Details
--------|------
aedcf7d | ZIOS-11452: Process legal hold hint flag when receiving message (#734)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.