Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generic message protobuf to 1.24 #33

Merged
merged 2 commits into from Jun 3, 2019

Conversation

Projects
None yet
5 participants
@typfel
Copy link
Member

commented Jun 3, 2019

What's new in this PR?

Update generic message protobuf to 1.24

@vytis

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

Would also be good to regenerate the Swift-based code

@codecov-io

This comment has been minimized.

Copy link

commented Jun 3, 2019

Codecov Report

Merging #33 into develop will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           develop     #33    +/-   ##
========================================
  Coverage        0%      0%            
========================================
  Files            4       4            
  Lines        10985   11197   +212     
========================================
- Misses       10985   11197   +212
@vytis

vytis approved these changes Jun 3, 2019

@alexaubry

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

@typfel Do we also need to get this in? wireapp/generic-message-proto#47

@typfel

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

@alexaubry yes, but I figured we can just bump it again later

@typfel

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

@zenkins release minor

@wire-bot wire-bot merged commit 9158dfd into develop Jun 3, 2019

4 of 6 checks passed

codecov/patch 0% of diff hit (target 50%)
Details
jenkins/merge-pr Build started for merge commit.
Details
codecov/project 0% (+0%) compared to 2d4298f
Details
license/cla Contributor License Agreement is signed.
Details
wire-ios-protos Build #20190603.3 succeeded
Details
wire-ios-protos (Test) Test succeeded
Details

@wire-bot wire-bot deleted the feature/legalhold-status branch Jun 3, 2019

zenkins pushed a commit that referenced this pull request Jun 3, 2019

Release 20.1.0
Diff with previous:
20.0.0...20.1.0

Commit  | Details
--------|------
9158dfd | Update generic message protobuf to 1.24 (#33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.