add secure random number generator as extension #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be good if @marcoconti83 or @raphaelrobert could check it for any deficiencies. |
Generated by |
|
I guess I missed the previous discussion but why can't we use |
|
@typfel although |
|
Basically to be on the safe side and use cryptographically safe random numbers. |
|
Ok |
|
Also, I'm not sure how to test this, is there something we can test? |
|
What are you going to use this function for? Where do you need a random UInt? |
|
@marcoconti83 when we obfuscate a text message, we use a random array index to replace each non-whitespace character with a random alphabetic character |
mikeger
approved these changes
Jan 3, 2018
zenkins
added a commit
that referenced
this pull request
Jan 3, 2018
Diff with previous: 18.1.1...18.2.0 Commits: b356ffc Merge pull request #32 from wireapp/feature/secure+random+integer 17e6734 add tests 4ecd036 guard against division by zero 1eb9b70 use overflow operator 9ce8dfd add secure random number generator as extension a6155c0 Merge pull request #31 from wireapp/feature/circleci 300baed Fix test results directory 0fffe38 Update config f03a108 Added CircleCI 2.0 config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What's in this PR?
I've added an extension to
UIntto provide a secure random number generator with an upper bound and no modulo bias. This was suggested by @vytis and I've used this page as a guide.