New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support opening links in SnowHaze and Brave #2202

Merged
merged 1 commit into from May 29, 2018

Conversation

Projects
None yet
5 participants
@mikeger
Member

mikeger commented May 29, 2018

What's new in this PR?

Issues

As suggested in the operational-security article, Wire would be better if it would support more of the independent browsers.

Solutions

Added the support for Brave and SnowHaze browsers. The integration is very similar to other (Chrome, Firefox, ...) browsers.

Fun fact

Both browsers are open-source: https://github.com/snowhaze/ and https://github.com/brave/

@mikeger mikeger requested a review from daehn May 29, 2018

@typfel

typfel approved these changes May 29, 2018

@daehn

daehn approved these changes May 29, 2018

@wire-bot

This comment has been minimized.

Collaborator

wire-bot commented May 29, 2018

9 Warnings
⚠️ ld: linking against a dylib which is not safe for use in application extensions: /Users/distiller/project/Carthage/Build/iOS/WireSyncEngine.framework/WireSyncEngine
⚠️ ld: linking against a dylib which is not safe for use in application extensions: /Users/distiller/project/Carthage/Build/iOS/WireRequestStrategy.framework/WireRequestStrategy
⚠️ ld: linking against a dylib which is not safe for use in application extensions: /Users/distiller/project/Carthage/Build/iOS/FormatterKit.framework/FormatterKit
⚠️ ld: linking against a dylib which is not safe for use in application extensions: /Users/distiller/project/Carthage/Build/iOS/PureLayout.framework/PureLayout
⚠️ ld: linking against a dylib which is not safe for use in application extensions: /Users/distiller/project/Carthage/Build/iOS/PINCache.framework/PINCache
⚠️ ld: linking against a dylib which is not safe for use in application extensions: /Users/distiller/project/Carthage/Build/iOS/avs.framework/avs
⚠️ ld: linking against a dylib which is not safe for use in application extensions: /Users/distiller/project/Carthage/Build/iOS/HockeySDK.framework/HockeySDK
⚠️ Carthage/Build/iOS/Classy.framework/Headers/CASUtilities.h#L28: this function declaration is not a prototype [-Wstrict-prototypes]
NSUInteger CASKeyDeviceSystemMajorVersion();
⚠️ Wire-iOS/Sources/UserInterface/Conversation/Content/ConversationContentViewController+PinchZoom.m#L80: assigning to ‘__strong id<MediaAsset>’ from incompatible type ‘UIImage * _Nullable’
image = [UIImage imageWithData:message.imageMessageData.imageData];

Generated by 🚫 Danger

@mikeger mikeger merged commit fc7cfd2 into develop May 29, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
danger/danger ⚠️ 9 Warnings. Don't worry, everything is fixable.
Details
license/cla Contributor License Agreement is signed.
Details

@mikeger mikeger deleted the feature/brave-snowhaze-support branch May 29, 2018

@codecov-io

This comment has been minimized.

codecov-io commented May 29, 2018

Codecov Report

Merging #2202 into develop will decrease coverage by 0.07%.
The diff coverage is 23.33%.

@@             Coverage Diff             @@
##           develop    #2202      +/-   ##
===========================================
- Coverage    34.01%   33.94%   -0.08%     
===========================================
  Files          795      795              
  Lines        50515    50505      -10     
===========================================
- Hits         17182    17143      -39     
- Misses       33333    33362      +29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment