Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Temp] Remove legal hold disabled alert #3465

Merged
merged 1 commit into from Jun 12, 2019

Conversation

Projects
None yet
3 participants
@alexaubry
Copy link
Contributor

commented Jun 12, 2019

What's new in this PR?

Issues

QA reported that this alert was shown mistakenly every time the user logs in, and it caused their nightly test passing rate to drop to 24%. We need to disable this alert until we have a proper mechanism for displaying it.

[Temp] Remove legal hold disabled alert
QA reported that this alert was shown mistakenly every time the user logs in, and it caused their nightly test passing rate to drop to 24%. We need to disable this alert until we have a proper mechanism for displaying it,

@billypchan billypchan merged commit a6f4211 into develop Jun 12, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
wire-ios Build #20190612.21 succeeded
Details

@billypchan billypchan deleted the fix/remove-legal-hold-disabled-alert branch Jun 12, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 12, 2019

Codecov Report

Merging #3465 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #3465      +/-   ##
===========================================
- Coverage    57.18%   57.17%   -0.01%     
===========================================
  Files          968      968              
  Lines        55082    55082              
===========================================
- Hits         31498    31493       -5     
- Misses       23584    23589       +5

billypchan added a commit that referenced this pull request Jun 13, 2019

Merge branch 'develop' into feature/swift-snapshot
* develop:
  [Temp] Remove legal hold disabled alert (#3465)
  Clean up Fingerprint Data to spaced string methods (#3464)
  Fix environment variable for tests (#3457)
  Synthesize property declared in extension (#3461)
  ZIOS-11452: Process legal hold hint flag when receiving message (#3459)
  feature: Inform user that they are no longer under legal hold (#3408)
  Fix log out not working from non active account (#3456)
  ZIOS-11429: Indicate legal hold in the share extension (#3438)
  Bump components
  do not zoom when scrollView.minimumZoomScale == scrollView.maximumZoomScale (#3455)
  Bump to avs 5.0.26, fixing video grp call flag (#3453)
  Bump to avs 5.0.25, fixing crashes/failures answering calls (#3452)
  Fix: "You started using *This device*" button doesn't work  (#3451)
  UserClientListViewController as ParticipantDeviceHeaderViewDelegate (#3450)
  Bump to avs 5.0.24 implementing CBR (#3449)
  Added answeredElsewhere case in CallQualityController switch (#3448)
  Fix: correctly end active call when starting a new one (#3445)
  Fix: group options in cell are not responsive to tapping (#3446)
  Fix: Double status indicators is shown on input bar (#3444)

billypchan added a commit that referenced this pull request Jun 13, 2019

Merge branch 'develop' into feature/ZIOS-11401-legalhold-activation-d…
…ialog

* develop:
  Feature/swift snapshot (#3411)
  [Temp] Remove legal hold disabled alert (#3465)

# Conflicts:
#	Wire-iOS/Sources/UserInterface/MainController/ZClientViewController+ZMUserObserver.swift

billypchan added a commit that referenced this pull request Jun 14, 2019

Merge branch 'develop' into fix/ZIOS-11464_camera_keyboard_GIF
* develop:
  Feature: legalhold activation dialog (#3463)
  Feature/swift snapshot (#3411)
  [Temp] Remove legal hold disabled alert (#3465)
  Clean up Fingerprint Data to spaced string methods (#3464)
  Fix environment variable for tests (#3457)
  Synthesize property declared in extension (#3461)
  ZIOS-11452: Process legal hold hint flag when receiving message (#3459)
  feature: Inform user that they are no longer under legal hold (#3408)
  Fix log out not working from non active account (#3456)
  ZIOS-11429: Indicate legal hold in the share extension (#3438)
  Bump components

billypchan added a commit that referenced this pull request Jun 19, 2019

Merge branch 'develop' into fix/ZIOS-10385-paste-multiple-images-
* develop:
  Feature: legalhold activation dialog (#3463)
  Feature/swift snapshot (#3411)
  [Temp] Remove legal hold disabled alert (#3465)
  Clean up Fingerprint Data to spaced string methods (#3464)
  Fix environment variable for tests (#3457)
  Synthesize property declared in extension (#3461)
  ZIOS-11452: Process legal hold hint flag when receiving message (#3459)
  feature: Inform user that they are no longer under legal hold (#3408)

billypchan added a commit that referenced this pull request Jun 20, 2019

Merge branch 'develop' into fix/ZIOS-11365-Chinese-paragraph
* develop: (115 commits)
  Bump components
  Bump to avs 5.0.28, fixing iOS crashes on simulator (#3475)
  Add public logs (#3472)
  Use mock core data with swift snapshot testing (#3468)
  Fix: Wrong list layout in the share extension (#3466)
  Bump components
  Revert "Bump components"
  Bump to avs 5.0.27, attempting to fix HockeyApp crashes (#3470)
  Bump components
  ZIOS-11401: Allow users to accept legal hold requests (#3469)
  Feature: legalhold activation dialog (#3463)
  Feature/swift snapshot (#3411)
  [Temp] Remove legal hold disabled alert (#3465)
  Clean up Fingerprint Data to spaced string methods (#3464)
  Fix environment variable for tests (#3457)
  Synthesize property declared in extension (#3461)
  ZIOS-11452: Process legal hold hint flag when receiving message (#3459)
  feature: Inform user that they are no longer under legal hold (#3408)
  Fix log out not working from non active account (#3456)
  ZIOS-11429: Indicate legal hold in the share extension (#3438)
  ...

# Conflicts:
#	Wire-iOS.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.