New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] video capture state #4879
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnxnguyen
requested changes
Feb 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good at tests.
Codecov Report
@@ Coverage Diff @@
## develop #4879 +/- ##
========================================
Coverage 60.86% 60.87%
========================================
Files 973 973
Lines 53893 53897 +4
========================================
+ Hits 32804 32809 +5
+ Misses 21089 21088 -1 |
KaterinaWire
approved these changes
Feb 1, 2021
johnxnguyen
approved these changes
Feb 1, 2021
David-Henner
added a commit
that referenced
this pull request
Feb 3, 2021
* stop capture when there is no self video stream * update capture state when needed * update capture state on didMoveToWindow * add tests
David-Henner
added a commit
that referenced
this pull request
Feb 5, 2021
* [Chore] bump version * [Chore] bump avs to 6.6.15 (#4880) * [Fix] video capture state (#4879) * stop capture when there is no self video stream * update capture state when needed * update capture state on didMoveToWindow * add tests * [Chore] bump avs to 6.6.17 * trigger * trigger * [Refactor] App lock config sync (#4891) * Don't update team feature in app root router * Pin components * Bump components * [Chore] bump sync engine (#4889) # Conflicts: # Cartfile # Cartfile.resolved Co-authored-by: David-Henner <david.henner@wire.com> Co-authored-by: John Nguyen <polyxo@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What's new in this PR?
start self preview capture only when video state is
.started