Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] video capture state #4879

Merged
merged 4 commits into from Feb 2, 2021
Merged

[Fix] video capture state #4879

merged 4 commits into from Feb 2, 2021

Conversation

David-Henner
Copy link
Contributor

What's new in this PR?

start self preview capture only when video state is .started

Copy link
Contributor

@johnxnguyen johnxnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good at tests.

@codecov-io
Copy link

Codecov Report

Merging #4879 (98a56c9) into develop (51484c0) will increase coverage by 0.00%.
The diff coverage is 88.88%.

@@           Coverage Diff            @@
##           develop    #4879   +/-   ##
========================================
  Coverage    60.86%   60.87%           
========================================
  Files          973      973           
  Lines        53893    53897    +4     
========================================
+ Hits         32804    32809    +5     
+ Misses       21089    21088    -1     

@David-Henner David-Henner merged commit 7e3c301 into develop Feb 2, 2021
1 check passed
@David-Henner David-Henner deleted the fix/video-capture-state branch February 2, 2021 08:15
David-Henner added a commit that referenced this pull request Feb 3, 2021
* stop capture when there is no self video stream

* update capture state when needed

* update capture state on didMoveToWindow

* add tests
David-Henner added a commit that referenced this pull request Feb 5, 2021
* [Chore] bump version

* [Chore] bump avs to 6.6.15 (#4880)

* [Fix] video capture state (#4879)

* stop capture when there is no self video stream

* update capture state when needed

* update capture state on didMoveToWindow

* add tests

* [Chore] bump avs to 6.6.17

* trigger

* trigger

* [Refactor] App lock config sync (#4891)

* Don't update team feature in app root router

* Pin components

* Bump components

* [Chore] bump sync engine (#4889)

# Conflicts:
#	Cartfile
#	Cartfile.resolved

Co-authored-by: David-Henner <david.henner@wire.com>

Co-authored-by: John Nguyen <polyxo@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants