refactor: Migrate App initialization from knockout to React #14033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #14033 +/- ##
==========================================
- Coverage 41.46% 41.09% -0.37%
==========================================
Files 599 604 +5
Lines 20795 20796 +1
Branches 4727 4719 -8
==========================================
- Hits 8622 8547 -75
- Misses 11076 11151 +75
- Partials 1097 1098 +1 |
atomrc
reviewed
Nov 3, 2022
atomrc
reviewed
Nov 3, 2022
atomrc
requested changes
Nov 3, 2022
atomrc
reviewed
Nov 3, 2022
atomrc
reviewed
Nov 3, 2022
Comment on lines
-32
to
-33
| data-uie-name="status-webapp" | ||
| data-uie-value="is-loading" |
There was a problem hiding this comment.
Is this migrated? I don't think I have seen those in the react component?
PatrykBuniX
reviewed
Nov 4, 2022
PatrykBuniX
reviewed
Nov 4, 2022
atomrc
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated Knockout rendering application to React.
Migrated with App-Loader, rendering content moved to id="wire-main".