Skip to content

Commit

Permalink
WT-2247, WT-2312: variable-length column-store in-memory page splits
Browse files Browse the repository at this point in the history
Review comment, remove an unnecessary set of the WT_REF.page_del field.
  • Loading branch information
keithbostic committed Jan 19, 2016
1 parent f19f26b commit d39d416
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions src/btree/bt_split.c
Expand Up @@ -1705,6 +1705,10 @@ __split_insert(WT_SESSION_IMPL *session, WT_REF *ref)
*
* The new WT_REF is not quite identical: we have to instantiate a key,
* and the new reference is visible to readers once the split completes.
*
* Don't copy any deleted page state: we may be splitting a page that
* was instantiated after a truncate and that history should not be
* carried onto these new child pages.
*/
WT_ERR(__wt_calloc_one(session, &split_ref[0]));
parent_incr += sizeof(WT_REF);
Expand Down Expand Up @@ -1746,13 +1750,6 @@ __split_insert(WT_SESSION_IMPL *session, WT_REF *ref)
} else
child->key.recno = ref->key.recno;

/*
* Don't copy any deleted page state: we may be splitting a page that
* was instantiated after a truncate and that history should not be
* carried onto these new child pages.
*/
child->page_del = NULL;

/*
* The second page in the split is a new WT_REF/page pair.
*/
Expand Down

0 comments on commit d39d416

Please sign in to comment.