New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SERVER-25846 Coverity analysis defect 99861: Dereference after null check #2993

Merged
merged 3 commits into from Aug 29, 2016

Conversation

Projects
None yet
2 participants
@keithbostic
Member

keithbostic commented Aug 29, 2016

@sueloverso, would you please review & merge?

SERVER-25846 Coverity analysis defect 99861: Dereference after null c…
…heck

Now the __wt_cond_alloc, __wt_cond_wait_signal and __wt_cond_signal
functions can panic on failure, they potentially indirect through the
WT_SESSION handle to panic the WT_CONNECTION structure. Fortunately,
they should not be called with a NULL WT_SESSION handle, remove the
tests for that condition, making Coverity happy.

@keithbostic keithbostic self-assigned this Aug 29, 2016

Missed a call to __wt_cond_wait that passed an explicit NULL WT_SESSION;
replace the NULL with the existing session handle.
@sueloverso

This comment has been minimized.

Show comment
Hide comment
@sueloverso

sueloverso Aug 29, 2016

Member

It failed the PR tester. ex_async dumped core.

Member

sueloverso commented Aug 29, 2016

It failed the PR tester. ex_async dumped core.

@keithbostic

This comment has been minimized.

Show comment
Hide comment
@keithbostic

keithbostic Aug 29, 2016

Member

Fixed and pushed.

Member

keithbostic commented Aug 29, 2016

Fixed and pushed.

@sueloverso

This comment has been minimized.

Show comment
Hide comment
@sueloverso

sueloverso Aug 29, 2016

Member

LGTM. Merge once PR testing completes.

Member

sueloverso commented Aug 29, 2016

LGTM. Merge once PR testing completes.

@keithbostic keithbostic merged commit e80ef3c into develop Aug 29, 2016

1 check passed

default Build finished.
Details

@michaelcahill michaelcahill deleted the server-25846-panic-null-session branch Aug 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment