Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WT-3120 Fix ordering problem in connection_close for filesystem loaded in an extension #3261

merged 5 commits into from Jan 23, 2017


Copy link

keithbostic commented Jan 23, 2017

Lint/Coverity. Some of the code was copied from example code, which is why there are changes there as well.

keithbostic added 4 commits Jan 23, 2017
Convert size_t and off_t to uintmax_t/PRIuMAX, not uint64_t/PRIu64.
suspicious_pointer_arithmetic: Adding allocated * 8UL /* sizeof (char
*) */ to pointer entries of type char ** is suspicious because adding
an integral value to this pointer automatically scales that value by the
size, 8 bytes, of the pointed-to type, char *. Most likely, the
multiplication by sizeof (char *) in this expression is extraneous and
should be eliminated.

I don't see a problem, but hopefully a slight restructuring will help.
Overwriting handle ret in ret = 12 leaks the handle.
dead_error_line: Execution cannot reach this statement: while (count > 0U)
null: At condition entries != NULL, the value of entries must be NULL.
dead_error_condition: The condition entries != NULL cannot be true.
@keithbostic keithbostic self-assigned this Jan 23, 2017
@keithbostic keithbostic requested a review from ddanderson Jan 23, 2017
Copy link

ddanderson left a comment

These changes LGTM, and I think they address the coverity issues.

already configured a default filesystem by the time the extension is

Add early-load configuration to the wt3120_filesys test.

Add code to WiredTiger that fails if a custom filesystem is configured
after we've already configured a default filesystem.

This comment has been minimized.

Copy link

ddanderson commented Jan 23, 2017

LGTM, merging.

@ddanderson ddanderson merged commit b2ab33d into develop Jan 23, 2017
1 check passed
1 check passed
default Build finished.
@keithbostic keithbostic deleted the wt-3120-lint-coverity branch Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.