Add some initial E2 tests #1981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the tests are quite minimal: a test for the E2 parser, and a regression test for #1975. Soon there will be a test harness command that runs all the test E2s and watches for errors.
These tests are for developers and so shouldn't be shipped to people who just install the addon through the workshop.
thegrb93
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request starts finally adding some tests for E2. It adds:
assert(condition: number[, message: string])Ideally, every bugfix or new feature on E2 from now on would be accompanied by a test. This pull request doesn't add a command to be able to run all the tests there are, but that would be a good feature to have.