Fix divide by zero when calculating Means #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 22, 2017 11:18
…es in the column are null
…h addresses this.
…ng about this some more it seems better to return a None value when there are no values to calculate a Mean of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing data, sometimes you end up with a column of null values. If this is then pushed into a pipeline of operations which include calculating the mean on that column, then the whole process errors out.
I've opted to return None in these situations. Originally, I planned to return '0' feeling it would be more in keeping with the expected data type from the mean operation. However, upon reflection, I think this would be a mistake as if the column normally contains '0' and '1' then it might be confusing and misleading.