Skip to content

Don't calculate precision of infinity #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 28, 2019
Merged

Don't calculate precision of infinity #726

merged 4 commits into from
Sep 28, 2019

Conversation

@jpmckinney
Copy link
Member

@jpmckinney jpmckinney commented Apr 27, 2019 •
edited
Loading

If value in max_precision is Decimal('Infinity'), then exponent gets set to 'F', causing an error. Similarly, if v in print_table is infinity, then format_decimal from Babel errors.

@jpmckinney
Copy link
Member Author

jpmckinney commented Apr 27, 2019

To get tests passing, removed Python 3.3, which reached end-of-life.

@jpmckinney jpmckinney mentioned this pull request Apr 27, 2019
Closed
@jpmckinney jpmckinney merged commit cfb165b into master Sep 28, 2019
@jpmckinney jpmckinney deleted the infinityerror branch September 28, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpmckinney