New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebJarController does not work on windows without precising library name in the url #159

Closed
tleveque opened this Issue Apr 15, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@tleveque

tleveque commented Apr 15, 2014

WebJarController compares url parts to absolute file path parts.
On windows, url contains slash, file path contains anti-slash.

There is no error when we define the library name into the url.

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Apr 15, 2014

Member

Did I already told you I hate windows ? ;-)

Need to find a better way to test everything on windows.

Member

cescoffier commented Apr 15, 2014

Did I already told you I hate windows ? ;-)

Need to find a better way to test everything on windows.

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Apr 15, 2014

Member

Issue reproduced.

Member

cescoffier commented Apr 15, 2014

Issue reproduced.

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Apr 15, 2014

Member

Actually the webjar tests are failing on Windows. Will have a look tomorrow.

Member

cescoffier commented Apr 15, 2014

Actually the webjar tests are failing on Windows. Will have a look tomorrow.

@cescoffier cescoffier added this to the 0.5 milestone Apr 15, 2014

@cescoffier cescoffier added the bug label May 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment