New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wisit does not support in-command auto-completation #169

Closed
cescoffier opened this Issue Apr 18, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@cescoffier
Member

cescoffier commented Apr 18, 2014

@barjo:

instance rou + tab should auto-complete to instance router

@barjo

This comment has been minimized.

Show comment
Hide comment
@barjo

barjo Apr 18, 2014

Member

In order to achieve this level of auto-completion we should execute the command 'instances' to retrieve the instances name first.

We can either cache the result or rerun the command each time the 'instance <> + tab' is called.

The second option can have a disturbing delay. A more sophisticated implementation would requires a smart cache which would be updated through the web-socket each time an instances is added or removed. However it seems a bit too much for the feature.

WDYT?

Member

barjo commented Apr 18, 2014

In order to achieve this level of auto-completion we should execute the command 'instances' to retrieve the instances name first.

We can either cache the result or rerun the command each time the 'instance <> + tab' is called.

The second option can have a disturbing delay. A more sophisticated implementation would requires a smart cache which would be updated through the web-socket each time an instances is added or removed. However it seems a bit too much for the feature.

WDYT?

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Apr 18, 2014

Member

Caching the initial result on instances would be good enough for now. anyway, how would you know the name of the instance ?

On 18 avr. 2014, at 09:14, Jonathan Bardin notifications@github.com wrote:

In order to achieve this level of auto-completion we should execute the command 'instances' to retrieve the instances name first.

We can either cache the result or rerun the command each time the 'instance <> + tab' is called.

The second option can have a disturbing delay. A more sophisticated implementation would requires a smart cache which would be updated through the web-socket each time an instances is added or removed. However it seems a bit too much for the feature.

WDYT?


Reply to this email directly or view it on GitHub.

Member

cescoffier commented Apr 18, 2014

Caching the initial result on instances would be good enough for now. anyway, how would you know the name of the instance ?

On 18 avr. 2014, at 09:14, Jonathan Bardin notifications@github.com wrote:

In order to achieve this level of auto-completion we should execute the command 'instances' to retrieve the instances name first.

We can either cache the result or rerun the command each time the 'instance <> + tab' is called.

The second option can have a disturbing delay. A more sophisticated implementation would requires a smart cache which would be updated through the web-socket each time an instances is added or removed. However it seems a bit too much for the feature.

WDYT?


Reply to this email directly or view it on GitHub.

@barjo

This comment has been minimized.

Show comment
Hide comment
@barjo

barjo Apr 18, 2014

Member

Yes in any case we need the list of all instances. For now I will retrieve the instances name when initializing the terminal.

Member

barjo commented Apr 18, 2014

Yes in any case we need the list of all instances. For now I will retrieve the instances name when initializing the terminal.

@barjo barjo closed this in 1f7c68b Apr 24, 2014

@cescoffier cescoffier added this to the 0.5 milestone Apr 30, 2014

@cescoffier cescoffier added the bug label May 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment