Add a random port support #205

Closed
cescoffier opened this Issue May 7, 2014 · 2 comments

Comments

Projects
None yet
1 participant
@cescoffier
Member

cescoffier commented May 7, 2014

No description provided.

@cescoffier cescoffier added this to the 0.6 milestone May 7, 2014

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier May 13, 2014

Member

HTTP and HTTPS ports can be 'random' if the are set to 0. However unlike the usual port 0 hack, our approach is a bit more reliable as we are really trying to bind on the port (and if used try another one, (30 attempts only)).

Notice that changes also impact the test API as it uses a random port from now, except if the http.port system property is explicitly set.

Member

cescoffier commented May 13, 2014

HTTP and HTTPS ports can be 'random' if the are set to 0. However unlike the usual port 0 hack, our approach is a bit more reliable as we are really trying to bind on the port (and if used try another one, (30 attempts only)).

Notice that changes also impact the test API as it uses a random port from now, except if the http.port system property is explicitly set.

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier May 13, 2014

Member

Last detail I forgot - the random ports are strictly greater to 9000. I prefer keeping the 8xxx range clean.

Member

cescoffier commented May 13, 2014

Last detail I forgot - the random ports are strictly greater to 9000. I prefer keeping the 8xxx range clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment