Allow JavaScriptCompilerMojo to generate .min.js files instead of -min.js #275

Closed
evrignaud opened this Issue Jul 15, 2014 · 2 comments

Comments

Projects
None yet
3 participants
@evrignaud

Hi,

Currently in our project we are generating minified files using a ".min" extension like jquery is doing. In the JavaScriptCompilerMojo it's hardcoded that minified files ends with "-min". Could it be possible to add a parameter to this mojo in order to specify the suffix to use like we can do for the yuicompressor-maven-plugin http://alchim.sourceforge.net/yuicompressor-maven-plugin/compress-mojo.html#suffix

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Jul 15, 2014

Member

Yes, we should add such support. I used "-" because I considered the output as an artifact, and "min" as classifier (copy from old code handling javascript artifacts).

Member

cescoffier commented Jul 15, 2014

Yes, we should add such support. I used "-" because I considered the output as an artifact, and "min" as classifier (copy from old code handling javascript artifacts).

@cescoffier cescoffier added this to the 0.7 milestone Jul 15, 2014

@jenf11 jenf11 closed this in 78261ee Jul 16, 2014

@jenf11

This comment has been minimized.

Show comment
Hide comment
@jenf11

jenf11 Jul 16, 2014

Contributor

Just added a "googleClosureMinifierSuffix" parameter to set the suffix. By default "-min" is used. The suffix has to be set in the pom.xml file (in the wisdom-maven-plugin configuration).

Contributor

jenf11 commented Jul 16, 2014

Just added a "googleClosureMinifierSuffix" parameter to set the suffix. By default "-min" is used. The suffix has to be set in the pom.xml file (in the wisdom-maven-plugin configuration).

@cescoffier cescoffier modified the milestones: 0.6.2, 0.7 Jul 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment