Wisdom as a service script improvement #311

Closed
vcavel opened this Issue Aug 20, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@vcavel

vcavel commented Aug 20, 2014

Hi,

I externalized the JVM_ARGS in the wisdom.sh script to have wisdom as a service

And my patch would be the following :

 27,28c27,28
< 
< 

---
> # Arguments for the JVM
> JVM_ARGS="-Dapplication.mode=${APPLICATION_MODE}"
42c42
<   export JVM_ARGS="-Dapplication.mode=${APPLICATION_MODE}"

---
>   export JVM_ARGS=${JVM_ARGS}
106c106
< exit 0
\ No newline at end of file

---
> exit 0

It just allows the users to add params to the JVM more easily, like a -Dhttp.port=80 (my case) for example.

It was already possible before, but I feel like externalizing the variable makes it easier (no hands in the code itself).

@cescoffier cescoffier added this to the 0.7 milestone Aug 20, 2014

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Aug 20, 2014

Member

Hi,

Sounds good, can you make a pull request ?

Member

cescoffier commented Aug 20, 2014

Hi,

Sounds good, can you make a pull request ?

@vcavel

This comment has been minimized.

Show comment
Hide comment
@vcavel

vcavel Aug 20, 2014

Sure, I'll take care of that tomorrow.

vcavel commented Aug 20, 2014

Sure, I'll take care of that tomorrow.

@cescoffier cescoffier closed this in 3883a7b Sep 1, 2014

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Sep 1, 2014

Member

Just applied your patch.

Member

cescoffier commented Sep 1, 2014

Just applied your patch.

@cescoffier cescoffier modified the milestones: 0.7, 0.6.3 Sep 1, 2014

@vcavel

This comment has been minimized.

Show comment
Hide comment
@vcavel

vcavel Oct 20, 2014

Sorry Clement, I've been super busy. Thank you!

vcavel commented Oct 20, 2014

Sorry Clement, I've been super busy. Thank you!

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Oct 20, 2014

Member

No problem, it was straightforward.

Member

cescoffier commented Oct 20, 2014

No problem, it was straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment