Unpack webjar #346

Closed
obigard opened this Issue Sep 11, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@obigard

obigard commented Sep 11, 2014

No description provided.

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Sep 12, 2014

Member

By unpacking webjar in target/webjars it would be possible to include less and js files in the project files.

Webjars should be unpacked as follows: target/webjars/_webjar_name_/_content_. So the version is stripped as well as the META-INF/webjars directories.

Member

cescoffier commented Sep 12, 2014

By unpacking webjar in target/webjars it would be possible to include less and js files in the project files.

Webjars should be unpacked as follows: target/webjars/_webjar_name_/_content_. So the version is stripped as well as the META-INF/webjars directories.

@cescoffier cescoffier added this to the 0.7 milestone Sep 12, 2014

@cescoffier cescoffier self-assigned this Sep 12, 2014

@cescoffier cescoffier added the feature label Sep 12, 2014

@cescoffier cescoffier modified the milestones: 0.7, 0.6.4 Sep 14, 2014

cescoffier added a commit that referenced this issue Sep 15, 2014

Fix #345
Refactor maven plugin integration test
Add support for #345
Add tests for #345 as well as #346
Add documentation

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
@jbrey

This comment has been minimized.

Show comment
Hide comment
@jbrey

jbrey Sep 25, 2014

Contributor

Hi Clement,

I've tried to update our version and maybe I miss something but it seems webjars are not unpacked to the target directory (even if the scope is not provided).

I've tried with a new project also and the result is the same.

Is there something to configure to have webjars extracted ?

Cheers
JB

Contributor

jbrey commented Sep 25, 2014

Hi Clement,

I've tried to update our version and maybe I miss something but it seems webjars are not unpacked to the target directory (even if the scope is not provided).

I've tried with a new project also and the result is the same.

Is there something to configure to have webjars extracted ?

Cheers
JB

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Sep 25, 2014

Member

Yes, you need to add the following configuration in the wisdom-maven-plugin configuration.

true

See: 
https://github.com/wisdom-framework/wisdom/blob/master/framework/wisdom-maven-plugin-it/src/it/projects/unpack-webjars/pom.xml#L119

By default, web jars are not unpacked to save some IOs. 

The documentation of the unpackWebJars parameter  is there:
http://wisdom-framework.org/wisdom-maven-plugin/0.6.4/initialize-mojo.html#unpackWebJars

On 25 septembre 2014 at 11:45:46, jbrey (notifications@github.com) wrote:

Hi Clement,

I've tried to update our version and maybe I miss something but it seems webjars are not unpacked to the target directory.

I've tried with a new project also and the result is the same.

Is there something to configure to have webjars extracted ?

Cheers
JB


Reply to this email directly or view it on GitHub.

Member

cescoffier commented Sep 25, 2014

Yes, you need to add the following configuration in the wisdom-maven-plugin configuration.

true

See: 
https://github.com/wisdom-framework/wisdom/blob/master/framework/wisdom-maven-plugin-it/src/it/projects/unpack-webjars/pom.xml#L119

By default, web jars are not unpacked to save some IOs. 

The documentation of the unpackWebJars parameter  is there:
http://wisdom-framework.org/wisdom-maven-plugin/0.6.4/initialize-mojo.html#unpackWebJars

On 25 septembre 2014 at 11:45:46, jbrey (notifications@github.com) wrote:

Hi Clement,

I've tried to update our version and maybe I miss something but it seems webjars are not unpacked to the target directory.

I've tried with a new project also and the result is the same.

Is there something to configure to have webjars extracted ?

Cheers
JB


Reply to this email directly or view it on GitHub.

@jbrey

This comment has been minimized.

Show comment
Hide comment
@jbrey

jbrey Sep 25, 2014

Contributor

It works.

Reading the document is often a good solution :), I was not looking to the good one... my mistake ...

Thanks!

Contributor

jbrey commented Sep 25, 2014

It works.

Reading the document is often a good solution :), I was not looking to the good one... my mistake ...

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment